X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Frender%2Finstancearray.cpp;h=a53a988105d410a3fd3d58be119876b43a58f040;hb=0d5406c66549a2cfc2fca701cc1c4972e7fd493a;hp=427976129d65b1a4e5f0c82caf725822111a44b7;hpb=a04e4054b3001d24a540a0e7b088d270f3e07c07;p=libs%2Fgl.git

diff --git a/source/render/instancearray.cpp b/source/render/instancearray.cpp
index 42797612..a53a9881 100644
--- a/source/render/instancearray.cpp
+++ b/source/render/instancearray.cpp
@@ -28,10 +28,9 @@ InstanceArray::InstanceArray(const Object &o):
 	matrix_offset(0)
 {
 	const Technique *tech = object.get_technique();
-	const Technique::PassMap &passes = tech->get_passes();
-	for(Technique::PassMap::const_iterator i=passes.begin(); i!=passes.end(); ++i)
+	for(const auto &kvp: tech->get_passes())
 	{
-		const Program *shprog = i->second.get_shader_program();
+		const Program *shprog = kvp.second.get_shader_program();
 		if(!shprog)
 			throw invalid_argument("InstanceArray::InstanceArray");
 
@@ -65,8 +64,8 @@ InstanceArray::InstanceArray(const Object &o):
 
 InstanceArray::~InstanceArray()
 {
-	for(vector<ObjectInstance *>::iterator i=instances.begin(); i!=instances.end(); ++i)
-		delete *i;
+	for(ObjectInstance *i: instances)
+		delete i;
 	delete vtx_setup;
 	delete instance_data;
 	delete instance_buffer;
@@ -94,7 +93,7 @@ void InstanceArray::append(ObjectInstance *inst)
 
 void InstanceArray::remove(ObjectInstance &inst)
 {
-	vector<ObjectInstance *>::iterator i = find(instances, &inst);
+	auto i = find(instances, &inst);
 	if(i==instances.end())
 		throw key_error(&inst);
 
@@ -110,9 +109,9 @@ void InstanceArray::update_instance_matrix(unsigned index)
 
 	const Matrix &m = *instances[index]->get_matrix();
 
-	float *d = instance_data->modify(instances.size()-1);
+	float *d = reinterpret_cast<float *>(instance_data->modify(instances.size()-1)+matrix_offset);
 	for(unsigned i=0; i<12; ++i)
-		d[matrix_offset+i] = m(i/4, i%4);
+		d[i] = m(i/4, i%4);
 }
 
 void InstanceArray::render(Renderer &renderer, Tag tag) const
@@ -141,12 +140,12 @@ void InstanceArray::render(Renderer &renderer, Tag tag) const
 	}
 	else
 	{
-		for(vector<ObjectInstance *>::const_iterator i=instances.begin(); i!=instances.end(); ++i)
+		for(ObjectInstance *i: instances)
 		{
-			const Matrix &m = *(*i)->get_matrix();
+			const Matrix &m = *i->get_matrix();
 			for(unsigned j=0; j<3; ++j)
 				glVertexAttrib4f(matrix_location+j, m(j, 0), m(j, 1), m(j, 2), m(j, 3));
-			(*i)->render(renderer, tag);
+			i->render(renderer, tag);
 		}
 	}
 }