X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fnet%2Fprotocol.cpp;h=402b84a0633cdeb4dbe45c463e2f9676af911709;hb=ede42d5bb352841e2e425972e12b8ef31ddf2123;hp=81e9d142a56f93615152a9bfb7b5040ffe05b8ab;hpb=92e8064d9f43ca3e28ce9832cfe475034ab98704;p=libs%2Fnet.git

diff --git a/source/net/protocol.cpp b/source/net/protocol.cpp
index 81e9d14..402b84a 100644
--- a/source/net/protocol.cpp
+++ b/source/net/protocol.cpp
@@ -14,14 +14,8 @@ Protocol::Protocol(unsigned npi):
 	header_def(0),
 	next_packet_id(npi)
 {
-	PacketDefBuilder<PacketHeader, NullSerializer<PacketHeader> >(*this, header_def, NullSerializer<PacketHeader>())
-		(&PacketHeader::type)(&PacketHeader::length);
-}
-
-Protocol::~Protocol()
-{
-	for(auto &kvp: packet_class_defs)
-		delete kvp.second;
+	PacketDefBuilder<PacketHeader, Serializer<PacketHeader>>(*this, header_def, Serializer<PacketHeader>())
+		.fields(&PacketHeader::type, &PacketHeader::length);
 }
 
 unsigned Protocol::get_next_packet_class_id()
@@ -30,17 +24,14 @@ unsigned Protocol::get_next_packet_class_id()
 	return next_id++;
 }
 
-void Protocol::add_packet(PacketDefBase *pdef)
+void Protocol::add_packet(unique_ptr<PacketDefBase> pdef)
 {
-	PacketDefBase *&ptr = packet_class_defs[pdef->get_class_id()];
+	unique_ptr<PacketDefBase> &ptr = packet_class_defs[pdef->get_class_id()];
 	if(ptr)
-	{
 		packet_id_defs.erase(ptr->get_id());
-		delete ptr;
-	}
-	ptr = pdef;
-	if(unsigned id = pdef->get_id())
-		packet_id_defs[id] = pdef;
+	ptr = move(pdef);
+	if(unsigned id = ptr->get_id())
+		packet_id_defs[id] = ptr.get();
 }
 
 const Protocol::PacketDefBase &Protocol::get_packet_by_class_id(unsigned id) const
@@ -56,11 +47,11 @@ const Protocol::PacketDefBase &Protocol::get_packet_by_id(unsigned id) const
 size_t Protocol::dispatch(ReceiverBase &rcv, const char *buf, size_t size) const
 {
 	PacketHeader header;
-	buf = header_def.deserialize(header, buf, buf+size);
+	const char *ptr = header_def.deserialize(header, buf, buf+size);
 	if(header.length>size)
 		throw bad_packet("truncated");
 	const PacketDefBase &pdef = get_packet_by_id(header.type);
-	const char *ptr = pdef.dispatch(rcv, buf, buf+header.length);
+	ptr = pdef.dispatch(rcv, ptr, ptr+header.length);
 	return ptr-buf;
 }
 
@@ -166,11 +157,6 @@ Protocol::PacketDefBase::PacketDefBase(unsigned i):
 { }
 
 
-Protocol::PacketHeader::PacketHeader():
-	type(0),
-	length(0)
-{ }
-
 Protocol::PacketHeader::PacketHeader(uint16_t t, uint16_t l):
 	type(t),
 	length(l)