X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fmesh.cpp;h=316e5a3aa9f72ecbcfb3d09e5c9bc09e3b79dfe0;hb=47af19a447e6c13257ca2d0aef606ea45f8a0d98;hp=26d660446b6c8c264c4fba19781069343282bdb6;hpb=9d6c244eb728336c64ee23d5c55e45c6696aa65c;p=libs%2Fgl.git

diff --git a/source/mesh.cpp b/source/mesh.cpp
index 26d66044..316e5a3a 100644
--- a/source/mesh.cpp
+++ b/source/mesh.cpp
@@ -1,6 +1,7 @@
 #include <msp/gl/extensions/arb_vertex_array_object.h>
 #include <msp/gl/extensions/arb_vertex_shader.h>
 #include "buffer.h"
+#include "error.h"
 #include "mesh.h"
 #include "renderer.h"
 
@@ -80,16 +81,17 @@ void Mesh::refresh() const
 	{
 		if(dirty&1)
 		{
-			unbind();
 			for(list<Batch>::const_iterator i=batches.begin(); i!=batches.end(); ++i)
 				i->refresh();
 		}
 
 		if(dirty&2)
 		{
-			glBindVertexArray(vao_id);
-			BufferAlias<ARRAY_BUFFER> vbuf_alias(*vbuf);
-			Bind bind_vbuf(vbuf_alias);
+			Bind bind_vbuf(vbuf, ARRAY_BUFFER);
+
+			bool bind_here = !current();
+			if(bind_here)
+				glBindVertexArray(vao_id);
 
 			const VertexFormat &fmt = vertices.get_format();
 			unsigned stride = get_stride(fmt)*sizeof(float);
@@ -108,7 +110,9 @@ void Mesh::refresh() const
 				ptr += sz;
 			}
 			glBindBuffer(ELEMENT_ARRAY_BUFFER, ibuf->get_id());
-			glBindVertexArray(0);
+
+			if(bind_here)
+				glBindVertexArray(0);
 		}
 
 		dirty = 0;
@@ -149,22 +153,19 @@ void Mesh::set_winding(const WindingTest *w)
 
 void Mesh::draw() const
 {
+	const Mesh *cur = current();
+	if(cur && cur!=this)
+		throw invalid_operation("Mesh::draw");
+
 	refresh();
 
 	if(!current())
-	{
 		vertices.apply();
-		if(ibuf)
-			ibuf->bind_to(ELEMENT_ARRAY_BUFFER);
-	}
-
+	Bind bind_ibuf(ibuf, ELEMENT_ARRAY_BUFFER);
 	Bind bind_winding(winding);
 
 	for(list<Batch>::const_iterator i=batches.begin(); i!=batches.end(); ++i)
 		i->draw();
-
-	if(!current() && ibuf)
-		Buffer::unbind_from(ELEMENT_ARRAY_BUFFER);
 }
 
 void Mesh::draw(Renderer &renderer) const
@@ -185,16 +186,8 @@ void Mesh::bind() const
 	called.  Thus unbind won't try to call a null function either. */
 	if(!vao_id)
 		unbind();
-	else
-	{
-		if(Buffer::current(ELEMENT_ARRAY_BUFFER))
-		{
-			unbind();
-			Buffer::unbind_from(ELEMENT_ARRAY_BUFFER);
-		}
-		if(set_current(this))
-			glBindVertexArray(vao_id);
-	}
+	else if(set_current(this))
+		glBindVertexArray(vao_id);
 }
 
 void Mesh::unbind()