X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Flinal%2Fvector.h;h=610ac2103a21ab83e0b58f88905e6d07c6962d2d;hb=291c11cf66e7083dc21fffea1afbdeaaad96077d;hp=152c26e66482e943e5837c5ddecc54fc9e7c2fde;hpb=5797fe0a5296952cb8f8643fdc6cabddee19a554;p=libs%2Fmath.git

diff --git a/source/linal/vector.h b/source/linal/vector.h
index 152c26e..610ac21 100644
--- a/source/linal/vector.h
+++ b/source/linal/vector.h
@@ -3,6 +3,7 @@
 
 #include <algorithm>
 #include <cmath>
+#include <ostream>
 
 namespace Msp {
 namespace LinAl {
@@ -78,9 +79,14 @@ public:
 
 	Vector();
 	Vector(const T *);
-	Vector(T, T);
-	Vector(T, T, T);
-	Vector(T, T, T, T);
+
+	/** Constructs a vector from an array of interleaved values.  Intended for
+	use by Matrix row accessor. */
+	Vector(const T *, unsigned);
+
+	template<typename... Args>
+	Vector(T, Args...);
+
 	template<typename U>
 	Vector(const Vector<U, N> &);
 
@@ -113,30 +119,22 @@ inline Vector<T, N>::Vector(const T *d)
 		(*this)[i] = d[i];
 }
 
-/* The compiler won't instantiate these unless they are used.  Trying to use
-them on the wrong class results in an error. */
-template<typename T, unsigned N>
-inline Vector<T, N>::Vector(T x_, T y_)
-{
-	this->VectorComponents<T, 2>::x = x_;
-	this->VectorComponents<T, 2>::y = y_;
-}
-
 template<typename T, unsigned N>
-inline Vector<T, N>::Vector(T x_, T y_, T z_)
+inline Vector<T, N>::Vector(const T *d, unsigned stride)
 {
-	this->VectorComponents<T, 3>::x = x_;
-	this->VectorComponents<T, 3>::y = y_;
-	this->VectorComponents<T, 3>::z = z_;
+	for(unsigned i=0; i<N; ++i)
+		(*this)[i] = d[i*stride];
 }
 
 template<typename T, unsigned N>
-inline Vector<T, N>::Vector(T x_, T y_, T z_, T w_)
-{
-	this->VectorComponents<T, 4>::x = x_;
-	this->VectorComponents<T, 4>::y = y_;
-	this->VectorComponents<T, 4>::z = z_;
-	this->VectorComponents<T, 4>::w = w_;
+template<typename... Args>
+inline Vector<T, N>::Vector(T x_, Args... v)
+{
+	static_assert(1+sizeof...(v)==N, "Incorrect number of arguments in Vector constructor");
+	(*this)[0] = x_;
+	unsigned i = 1;
+	for(auto c: std::initializer_list<T> { static_cast<T>(v)... })
+		(*this)[i++] = c;
 }
 
 template<typename T, unsigned N>
@@ -161,9 +159,9 @@ template<typename T, unsigned N>
 inline Vector<T, N+1> compose(T s, const Vector<T, N> &v)
 {
 	Vector<T, N+1> r;
+	r[0] = s;
 	for(unsigned i=0; i<N; ++i)
-		r[i] = v[i];
-	r[N] = s;
+		r[i+1] = v[i];
 	return r;
 }
 
@@ -313,6 +311,20 @@ inline Vector<T, 3> cross(const Vector<T, 3> &v1, const Vector<T, 3> &v2)
 	return Vector<T, 3>(v1.y*v2.z-v1.z*v2.y, v1.z*v2.x-v1.x*v2.z, v1.x*v2.y-v1.y*v2.x);
 }
 
+template<typename T, unsigned N>
+inline std::ostream &operator<<(std::ostream &s, const Vector<T, N> &v)
+{
+	s << "Vector" << N << '(';
+	for(unsigned i=0; i<N; ++i)
+	{
+		if(i)
+			s << ", ";
+		s << v[i];
+	}
+	s << ')';
+	return s;
+}
+
 } // namespace LinAl
 } // namespace Msp