X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fglsl%2Fvalidate.cpp;h=f12177db4a4236109f4060ffc72c13098f66093f;hb=7ab4261d281c7885bbdfb0a782ed231b2cd08293;hp=ce30c2abdf44fe9156476e9eba145063c90fde43;hpb=e9a898f315b5d1396f196d785913a283c30940f2;p=libs%2Fgl.git

diff --git a/source/glsl/validate.cpp b/source/glsl/validate.cpp
index ce30c2ab..f12177db 100644
--- a/source/glsl/validate.cpp
+++ b/source/glsl/validate.cpp
@@ -1,5 +1,5 @@
-#include <algorithm>
 #include <cstring>
+#include <msp/core/algorithm.h>
 #include <msp/core/raii.h>
 #include <msp/strings/format.h>
 #include <msp/strings/utils.h>
@@ -12,11 +12,6 @@ namespace Msp {
 namespace GL {
 namespace SL {
 
-Validator::Validator():
-	stage(0),
-	last_provoker(0)
-{ }
-
 void Validator::diagnose(Node &node, Node &provoking_node, Diagnostic::Severity severity, const string &message)
 {
 	Diagnostic diag;
@@ -39,13 +34,6 @@ void Validator::add_info(Node &node, const string &message)
 }
 
 
-DeclarationValidator::DeclarationValidator():
-	scope(GLOBAL),
-	iface_layout(0),
-	iface_block(0),
-	variable(0)
-{ }
-
 const char *DeclarationValidator::describe_variable(ScopeType scope)
 {
 	switch(scope)
@@ -266,8 +254,13 @@ void DeclarationValidator::visit(VariableDeclaration &var)
 	}
 	else if(kind==BasicTypeDeclaration::VOID)
 		error(var, "Type 'void' not allowed on variable");
-	else if(kind==BasicTypeDeclaration::BOOL && !var.interface.empty() && var.source!=BUILTIN_SOURCE)
-		error(var, "Type 'bool' not allowed on interface variable");
+	else if(kind==BasicTypeDeclaration::BOOL && var.source!=BUILTIN_SOURCE)
+	{
+		if(scope==INTERFACE_BLOCK)
+			error(var, "Type 'bool' not allowed in an interface block");
+		else if(!var.interface.empty())
+			error(var, "Type 'bool' not allowed on interface variable");
+	}
 
 	if(var.init_expression)
 	{
@@ -305,10 +298,6 @@ void DeclarationValidator::visit(FunctionDeclaration &func)
 }
 
 
-IdentifierValidator::IdentifierValidator():
-	anonymous_block(false)
-{ }
-
 void IdentifierValidator::multiple_definition(const string &name, Statement &statement, Statement &previous)
 {
 	error(statement, format("Multiple definition of %s", name));
@@ -506,15 +495,19 @@ void ReferenceValidator::visit(FunctionDeclaration &func)
 }
 
 
-ExpressionValidator::ExpressionValidator():
-	current_function(0),
-	constant_expression(false)
-{ }
-
 void ExpressionValidator::visit(VariableReference &var)
 {
-	if(var.declaration && constant_expression && !var.declaration->constant)
-		error(var, format("Reference to non-constant variable '%s' in a constant expression", var.name));
+	if(var.declaration && constant_expression)
+	{
+		if(!var.declaration->constant)
+			error(var, format("Reference to non-constant variable '%s' in a constant expression", var.name));
+		else if(var.declaration->layout && constant_expression==FIXED_CONSTANT)
+		{
+			auto i = find_member(var.declaration->layout->qualifiers, string("constant_id"), &Layout::Qualifier::name);
+			if(i!=var.declaration->layout->qualifiers.end())
+				error(var, format("Reference to specialization constant '%s' in a fixed constant expression", var.name));
+		}
+	}
 }
 
 void ExpressionValidator::visit(InterfaceBlockReference &iface)
@@ -540,7 +533,7 @@ void ExpressionValidator::visit(Swizzle &swizzle)
 		int flavour = -1;
 		for(unsigned i=0; i<swizzle.count; ++i)
 		{
-			unsigned component_flavour = (find(component_names, component_names+12, swizzle.component_group[i])-component_names)/4;
+			unsigned component_flavour = (std::find(component_names, component_names+12, swizzle.component_group[i])-component_names)/4;
 			if(flavour==-1)
 				flavour = component_flavour;
 			else if(flavour>=0 && component_flavour!=static_cast<unsigned>(flavour))
@@ -630,6 +623,12 @@ void ExpressionValidator::visit(TernaryExpression &ternary)
 	TraversingVisitor::visit(ternary);
 }
 
+void ExpressionValidator::visit(StructDeclaration &strct)
+{
+	SetFlag set_struct(in_struct);
+	TraversingVisitor::visit(strct);
+}
+
 void ExpressionValidator::visit(VariableDeclaration &var)
 {
 	if(var.init_expression && var.init_expression->type && var.type_declaration && var.init_expression->type!=var.type_declaration)
@@ -640,12 +639,20 @@ void ExpressionValidator::visit(VariableDeclaration &var)
 		var.layout->visit(*this);
 	if(var.init_expression)
 	{
-		SetFlag set_const(constant_expression, var.constant);
+		ConstantKind const_kind = (var.constant ? SPEC_CONSTANT : NOT_CONSTANT);
+		if(var.layout)
+		{
+			auto i = find_member(var.layout->qualifiers, string("constant_id"), &Layout::Qualifier::name);
+			if(i!=var.layout->qualifiers.end())
+				const_kind = FIXED_CONSTANT;
+		}
+
+		SetForScope<ConstantKind> set_const(constant_expression, const_kind);
 		TraversingVisitor::visit(var.init_expression);
 	}
 	if(var.array_size)
 	{
-		SetFlag set_const(constant_expression);
+		SetForScope<ConstantKind> set_const(constant_expression, (in_struct || !var.interface.empty() ? FIXED_CONSTANT : SPEC_CONSTANT));
 		TraversingVisitor::visit(var.array_size);
 	}
 }
@@ -698,10 +705,6 @@ void ExpressionValidator::visit(Return &ret)
 }
 
 
-FlowControlValidator::FlowControlValidator():
-	reachable(true)
-{ }
-
 void FlowControlValidator::visit(Block &block)
 {
 	for(const RefPtr<Statement> &s: block.body)