X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fglsl%2Fvalidate.cpp;h=4523b7461730e4fadb6a2faec9d904cea70d1c42;hb=4181ceb89a2d538712c81826da610e7e8583e9a5;hp=e6f0c653e45f4ad9e62c108084867dc4374c11c9;hpb=d80750e7c20ea061f210b756196cc844b762b852;p=libs%2Fgl.git

diff --git a/source/glsl/validate.cpp b/source/glsl/validate.cpp
index e6f0c653..4523b746 100644
--- a/source/glsl/validate.cpp
+++ b/source/glsl/validate.cpp
@@ -1,3 +1,5 @@
+#include <algorithm>
+#include <cstring>
 #include <msp/core/raii.h>
 #include <msp/strings/format.h>
 #include "validate.h"
@@ -148,18 +150,28 @@ void DeclarationValidator::visit(InterfaceBlock &iface)
 	if(!iface.instance_name.empty())
 		check_definition(iface.instance_name, iface);
 
-	SetFlag set_anon(anonymous_block, iface.instance_name.empty());
-	TraversingVisitor::visit(iface);
+	if(iface.instance_name.empty() && iface.struct_declaration)
+	{
+		// Inject anonymous interface block members into the global scope
+		const map<string, VariableDeclaration *> &iface_vars = iface.struct_declaration->members.variables;
+		for(map<string, VariableDeclaration *>::const_iterator j=iface_vars.begin(); j!=iface_vars.end(); ++j)
+			check_definition(j->first, *j->second);
+	}
 }
 
 void DeclarationValidator::visit(FunctionDeclaration &func)
 {
 	if(Statement *previous = find_definition(func.name))
-		if(!dynamic_cast<FunctionDeclaration *>(previous))
+	{
+		FunctionDeclaration *prev_func = dynamic_cast<FunctionDeclaration *>(previous);
+		if(prev_func && prev_func->definition==&func)
+			declarations[current_block][func.name] = &func;
+		else
 			multiple_definition(format("'%s'", func.name), func, *previous);
+	}
+	else
+		record_definition(func.name, func);
 
-	if(func.definition==&func)
-		check_definition(func.name, func);
 	TraversingVisitor::visit(func);
 }
 
@@ -184,6 +196,13 @@ void ReferenceValidator::visit(VariableReference &var)
 		error(var, format("Use of unlinked input variable '%s'", var.name));
 }
 
+void ReferenceValidator::visit(MemberAccess &memacc)
+{
+	if(memacc.left->type && !memacc.declaration)
+		error(memacc, format("Use of undeclared member '%s'", memacc.member));
+	TraversingVisitor::visit(memacc);
+}
+
 void ReferenceValidator::visit(InterfaceBlockReference &iface)
 {
 	/* An interface block reference without a declaration should be impossible
@@ -201,6 +220,13 @@ void ReferenceValidator::visit(VariableDeclaration &var)
 	TraversingVisitor::visit(var);
 }
 
+void ReferenceValidator::visit(InterfaceBlock &iface)
+{
+	if(!iface.struct_declaration)
+		error(iface, format("Interface block '%s %s' lacks a struct declaration", iface.interface, iface.name));
+	TraversingVisitor::visit(iface);
+}
+
 void ReferenceValidator::visit(FunctionDeclaration &func)
 {
 	if(!func.return_type_declaration)
@@ -208,6 +234,95 @@ void ReferenceValidator::visit(FunctionDeclaration &func)
 	TraversingVisitor::visit(func);
 }
 
+
+void ExpressionValidator::visit(Swizzle &swizzle)
+{
+	unsigned size = 0;
+	if(BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(swizzle.left->type))
+	{
+		if(basic->kind==BasicTypeDeclaration::INT || basic->kind==BasicTypeDeclaration::FLOAT)
+			size = 1;
+		else if(basic->kind==BasicTypeDeclaration::VECTOR)
+			size = basic->size;
+	}
+
+	if(size)
+	{
+		static const char component_names[] = { 'x', 'y', 'z', 'w', 'r', 'g', 'b', 'a', 's', 't', 'p', 'q' };
+		int flavour = -1;
+		for(unsigned i=0; i<swizzle.count; ++i)
+		{
+			unsigned component_flavour = (find(component_names, component_names+12, swizzle.component_group[i])-component_names)/4;
+			if(flavour==-1)
+				flavour = component_flavour;
+			else if(flavour>=0 && component_flavour!=static_cast<unsigned>(flavour))
+			{
+				error(swizzle, format("Flavour of swizzle component '%c' is inconsistent with '%c'",
+					swizzle.component_group[i], swizzle.component_group[0]));
+				flavour = -2;
+			}
+
+			if(swizzle.components[i]>=size)
+				error(swizzle, format("Access to component '%c' which is not present in '%s'",
+					swizzle.component_group[i], swizzle.left->type->name));
+		}
+	}
+	else if(swizzle.left->type)
+		error(swizzle, format("Swizzle applied to '%s' which is neither a scalar nor a vector", swizzle.left->type->name));
+
+	TraversingVisitor::visit(swizzle);
+}
+
+void ExpressionValidator::visit(UnaryExpression &unary)
+{
+	if(unary.expression->type)
+	{
+		if(!unary.type)
+			error(unary, format("No matching operator '%s' found for '%s'", unary.oper->token, unary.expression->type->name));
+		else if((unary.oper->token[1]=='+' || unary.oper->token[1]=='-') && !unary.expression->lvalue)
+			error(unary, format("Operand of '%s' is not an lvalue", unary.oper->token));
+	}
+	TraversingVisitor::visit(unary);
+}
+
+void ExpressionValidator::visit(BinaryExpression &binary)
+{
+	if(!binary.type && binary.left->type && binary.right->type)
+		error(binary, format("No matching operator '%s' found for '%s' and '%s'",
+			binary.oper->token, binary.left->type->name, binary.right->type->name));
+	TraversingVisitor::visit(binary);
+}
+
+void ExpressionValidator::visit(Assignment &assign)
+{
+	if(assign.left->type)
+	{
+		if(!assign.left->lvalue)
+			error(assign, "Target of assignment is not an lvalue");
+		if(assign.right->type)
+		{
+			if(assign.oper->token[0]!='=')
+			{
+				if(!assign.type)
+					error(assign, format("No matching operator '%s' found for '%s' and '%s'",
+						string(assign.oper->token, strlen(assign.oper->token)-1), assign.left->type->name, assign.right->type->name));
+			}
+			else if(assign.left->type!=assign.right->type)
+				error(assign, format("Assignment to variable of type '%s' from expression of incompatible type '%s'",
+					assign.left->type->name, assign.right->type->name));
+		}
+	}
+	TraversingVisitor::visit(assign);
+}
+
+void ExpressionValidator::visit(VariableDeclaration &var)
+{
+	if(var.init_expression && var.init_expression->type && var.type_declaration && var.init_expression->type!=var.type_declaration)
+		error(var, format("Initializing a variable of type '%s' with an expression of incompatible type '%s'",
+			var.type_declaration->name, var.init_expression->type->name));
+	TraversingVisitor::visit(var);
+}
+
 } // namespace SL
 } // namespace GL
 } // namespace Msp