X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fglsl%2Foptimize.h;h=ed016ca0b9ddd26dd5e8e871b25a0f15484e2881;hb=3f899b1fc2e04f4fe74c99ad3e8ebb900c257214;hp=698aa0b2617efd3ef1f6a98348aa754b19f04862;hpb=696a97bd7411d69953c1a9e4b5f3dfb4c1d848f1;p=libs%2Fgl.git

diff --git a/source/glsl/optimize.h b/source/glsl/optimize.h
index 698aa0b2..ed016ca0 100644
--- a/source/glsl/optimize.h
+++ b/source/glsl/optimize.h
@@ -10,11 +10,11 @@ namespace Msp {
 namespace GL {
 namespace SL {
 
-class InlineableFunctionLocator: public StageVisitor
+/** Finds functions which are candidates for inlining.  Currently this means
+functions which have no parameters, are only called once, and that call occurs
+after the definition of the function. */
+class InlineableFunctionLocator: private TraversingVisitor
 {
-public:
-	typedef std::set<FunctionDeclaration *> ResultType;
-
 private:
 	std::map<FunctionDeclaration *, unsigned> refcounts;
 	std::set<FunctionDeclaration *> inlineable;
@@ -23,13 +23,17 @@ private:
 public:
 	InlineableFunctionLocator();
 
-	const ResultType &get_result() const { return inlineable; }
-	using StageVisitor::visit;
+	const std::set<FunctionDeclaration *> &apply(Stage &s) { s.content.visit(*this); return inlineable; }
+
+private:
 	virtual void visit(FunctionCall &);
 	virtual void visit(FunctionDeclaration &);
 };
 
-class FunctionInliner: public StageVisitor
+/** Inlines functions.  Internally uses InlineableFunctionLocator to find
+candidate functions.  Only functions which consist of a single return statement
+are inlined. */
+class FunctionInliner: private TraversingVisitor
 {
 private:
 	std::set<FunctionDeclaration *> inlineable;
@@ -38,12 +42,12 @@ private:
 
 public:
 	FunctionInliner();
-	FunctionInliner(const std::set<FunctionDeclaration *> &);
+
+	void apply(Stage &);
 
 private:
 	void visit_and_inline(RefPtr<Expression> &);
-public:
-	using StageVisitor::visit;
+
 	virtual void visit(Block &);
 	virtual void visit(UnaryExpression &);
 	virtual void visit(BinaryExpression &);
@@ -53,17 +57,22 @@ public:
 	virtual void visit(Return &);
 };
 
-class ConstantConditionEliminator: public BlockModifier
+/** Removes conditional statements and loops where the condition can be
+determined as constant at compile time. */
+class ConstantConditionEliminator: private TraversingVisitor
 {
 private:
-	unsigned scope_level;
 	bool record_only;
 	ExpressionEvaluator::ValueMap variable_values;
+	NodeList<Statement>::iterator insert_point;
+	std::set<Node *> nodes_to_remove;
 
 public:
 	ConstantConditionEliminator();
 
-	using StageVisitor::visit;
+	void apply(Stage &);
+
+private:
 	virtual void visit(Block &);
 	virtual void visit(UnaryExpression &);
 	virtual void visit(Assignment &);
@@ -72,11 +81,10 @@ public:
 	virtual void visit(Iteration &);
 };
 
-class UnusedVariableLocator: public StageVisitor
+/** Removes variable declarations with no references to them.  Assignment
+statements where the result is not used are also removed. */
+class UnusedVariableRemover: private TraversingVisitor
 {
-public:
-	typedef std::set<Node *> ResultType;
-
 private:
 	struct VariableInfo
 	{
@@ -97,16 +105,15 @@ private:
 	Assignment *assignment;
 	bool assignment_target;
 	bool assign_to_subscript;
-	bool global_scope;
 
 public:
-	UnusedVariableLocator();
+	UnusedVariableRemover();
+
+	bool apply(Stage &);
 
-	virtual void apply(Stage &);
-	const ResultType &get_result() const { return unused_nodes; }
 private:
-	using StageVisitor::visit;
 	virtual void visit(VariableReference &);
+	virtual void visit(InterfaceBlockReference &);
 	virtual void visit(MemberAccess &);
 	virtual void visit(BinaryExpression &);
 	virtual void visit(Assignment &);
@@ -122,18 +129,17 @@ private:
 	virtual void visit(Iteration &);
 };
 
-class UnusedFunctionLocator: public StageVisitor
+/** Removes function declarations with no references to them. */
+class UnusedFunctionRemover: private TraversingVisitor
 {
-public:
-	typedef std::set<Node *> ResultType;
-
 private:
 	std::set<Node *> unused_nodes;
 	std::set<FunctionDeclaration *> used_definitions;
 
 public:
-	const ResultType &get_result() const { return unused_nodes; }
-	using StageVisitor::visit;
+	bool apply(Stage &s);
+
+private:
 	virtual void visit(FunctionCall &);
 	virtual void visit(FunctionDeclaration &);
 };