X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fglsl%2Ffinalize.cpp;h=d840648bbc3ec0135bbb02b4dc47350cf753f03f;hb=08d3b5a55fad7439b47fc93d8ba604cbeb7e19ca;hp=fb136e33c7dbc79fd03706ba6ef3450d4906fe5c;hpb=acd7bb6e23e2aff9934ecf32852c62ba72c13574;p=libs%2Fgl.git

diff --git a/source/glsl/finalize.cpp b/source/glsl/finalize.cpp
index fb136e33..d840648b 100644
--- a/source/glsl/finalize.cpp
+++ b/source/glsl/finalize.cpp
@@ -75,7 +75,12 @@ void LocationAllocator::apply(Module &module, const Features &f, bool a)
 	for(VariableDeclaration *b: unbound_blocks)
 		bind_uniform(b->layout, b->block_declaration->block_name, features.uniform_binding_range);
 	for(VariableDeclaration *t: unbound_textures)
-		bind_uniform(t->layout, t->name, features.texture_binding_range);
+	{
+		const TypeDeclaration *base_type = get_ultimate_base_type(t->type_declaration);
+		unsigned range = (static_cast<const ImageTypeDeclaration *>(base_type)->sampled ?
+			features.texture_binding_range : features.storage_texture_binding_range);
+		bind_uniform(t->layout, t->name, range);
+	}
 }
 
 void LocationAllocator::apply(Stage &stage)
@@ -168,12 +173,11 @@ void LocationAllocator::bind_uniform(RefPtr<Layout> &layout, const string &name,
 
 bool LocationAllocator::visit_uniform(const string &name, RefPtr<Layout> &layout)
 {
-	int desc_set = 0;
+	int desc_set = get_layout_value(layout.get(), "set");
 	int bind_point = get_layout_value(layout.get(), "binding");
 
 	if(features.target_api==VULKAN)
 	{
-		desc_set = get_layout_value(layout.get(), "set");
 		if(desc_set<0 && bind_point>=0)
 		{
 			desc_set = 0;
@@ -183,6 +187,11 @@ bool LocationAllocator::visit_uniform(const string &name, RefPtr<Layout> &layout
 		if(desc_set>=0)
 			uniforms[name].desc_set = desc_set;
 	}
+	else if(desc_set>=0 && bind_point<0)
+	{
+		auto i = find_member(layout->qualifiers, string("set"), &Layout::Qualifier::name);
+		layout->qualifiers.erase(i);
+	}
 
 	if(bind_point>=0)
 	{
@@ -247,9 +256,42 @@ void DepthRangeConverter::apply(Stage &stage, const Features &features)
 	stage.content.visit(*this);
 }
 
+void DepthRangeConverter::visit(VariableReference &var)
+{
+	const StructDeclaration *strct = dynamic_cast<const StructDeclaration *>(var.type);
+	r_gl_pervertex = (strct && strct->block_name=="gl_PerVertex");
+}
+
+void DepthRangeConverter::visit(MemberAccess &memacc)
+{
+	r_gl_pervertex = false;
+	memacc.left->visit(*this);
+	r_gl_position = (r_gl_pervertex && memacc.member=="gl_Position");
+}
+
+void DepthRangeConverter::visit(Swizzle &swiz)
+{
+	r_gl_position = false;
+	swiz.left->visit(*this);
+	if(assignment_target && r_gl_position && swiz.count==1 && swiz.components[0]==2)
+		r_position_z_assigned = true;
+}
+
+void DepthRangeConverter::visit(Assignment &assign)
+{
+	{
+		SetFlag set_target(assignment_target);
+		assign.left->visit(*this);
+	}
+	assign.right->visit(*this);
+}
+
 void DepthRangeConverter::visit(FunctionDeclaration &func)
 {
-	if(func.definition==&func && func.name=="main")
+	r_position_z_assigned = false;
+	TraversingVisitor::visit(func);
+
+	if(func.definition==&func && func.name=="main" && !r_position_z_assigned)
 	{
 		VariableReference *position = new VariableReference;
 		position->name = "gl_Position";
@@ -429,24 +471,34 @@ void StructuralFeatureConverter::visit(RefPtr<Expression> &expr)
 
 bool StructuralFeatureConverter::supports_stage(Stage::Type st) const
 {
-	if(st==Stage::GEOMETRY)
+	if(st==Stage::TESS_CONTROL || st==Stage::TESS_EVAL)
+	{
+		if(features.target_api==OPENGL_ES)
+			return check_version(Version(3, 20));
+		else
+			return check_version(Version(4, 0));
+	}
+	else if(st==Stage::GEOMETRY)
 	{
-		if(features.target_api==VULKAN)
-			return true;
-		else if(features.target_api==OPENGL_ES)
+		if(features.target_api==OPENGL_ES)
 			return check_version(Version(3, 20));
 		else
 			return check_version(Version(1, 50));
 	}
+	else if(st==Stage::COMPUTE)
+	{
+		if(features.target_api==OPENGL_ES)
+			return check_version(Version(3, 10));
+		else
+			return check_version(Version(4, 30));
+	}
 	else
 		return true;
 }
 
 bool StructuralFeatureConverter::supports_unified_interface_syntax() const
 {
-	if(features.target_api==VULKAN)
-		return true;
-	else if(features.target_api==OPENGL_ES)
+	if(features.target_api==OPENGL_ES)
 		return check_version(Version(3, 0));
 	else
 		return check_version(Version(1, 30));
@@ -484,9 +536,7 @@ void StructuralFeatureConverter::visit(Assignment &assign)
 
 bool StructuralFeatureConverter::supports_unified_sampling_functions() const
 {
-	if(features.target_api==VULKAN)
-		return true;
-	else if(features.target_api==OPENGL_ES)
+	if(features.target_api==OPENGL_ES)
 		return check_version(Version(3, 0));
 	else
 		return check_version(Version(1, 30));
@@ -531,9 +581,7 @@ void StructuralFeatureConverter::visit(FunctionCall &call)
 
 bool StructuralFeatureConverter::supports_interface_blocks(const string &iface) const
 {
-	if(features.target_api==VULKAN)
-		return true;
-	else if(features.target_api==OPENGL_ES)
+	if(features.target_api==OPENGL_ES)
 	{
 		if(iface=="uniform")
 			return check_version(Version(3, 0));
@@ -587,9 +635,7 @@ void QualifierConverter::apply()
 
 bool QualifierConverter::supports_interface_layouts() const
 {
-	if(features.target_api==VULKAN)
-		return true;
-	else if(features.target_api==OPENGL_ES)
+	if(features.target_api==OPENGL_ES)
 		return check_version(Version(3, 0));
 	else if(check_version(Version(3, 30)))
 		return true;
@@ -601,9 +647,7 @@ bool QualifierConverter::supports_interface_layouts() const
 
 bool QualifierConverter::supports_stage_interface_layouts() const
 {
-	if(features.target_api==VULKAN)
-		return true;
-	else if(features.target_api==OPENGL_ES)
+	if(features.target_api==OPENGL_ES)
 		return check_version(Version(3, 10));
 	else if(check_version(Version(4, 10)))
 		return true;
@@ -613,9 +657,7 @@ bool QualifierConverter::supports_stage_interface_layouts() const
 
 bool QualifierConverter::supports_centroid_sampling() const
 {
-	if(features.target_api==VULKAN)
-		return true;
-	else if(features.target_api==OPENGL_ES)
+	if(features.target_api==OPENGL_ES)
 		return check_version(Version(3, 0));
 	else if(check_version(Version(1, 20)))
 		return true;
@@ -625,9 +667,7 @@ bool QualifierConverter::supports_centroid_sampling() const
 
 bool QualifierConverter::supports_sample_sampling() const
 {
-	if(features.target_api==VULKAN)
-		return true;
-	else if(features.target_api==OPENGL_ES)
+	if(features.target_api==OPENGL_ES)
 		return check_version(Version(3, 20));
 	else if(check_version(Version(4, 0)))
 		return true;
@@ -637,9 +677,7 @@ bool QualifierConverter::supports_sample_sampling() const
 
 bool QualifierConverter::supports_uniform_location() const
 {
-	if(features.target_api==VULKAN)
-		return false;
-	else if(features.target_api==OPENGL_ES)
+	if(features.target_api==OPENGL_ES)
 		return check_version(Version(3, 10));
 	else if(check_version(Version(4, 30)))
 		return true;
@@ -649,9 +687,7 @@ bool QualifierConverter::supports_uniform_location() const
 
 bool QualifierConverter::supports_binding() const
 {
-	if(features.target_api==VULKAN)
-		return true;
-	else if(features.target_api==OPENGL_ES)
+	if(features.target_api==OPENGL_ES)
 		return check_version(Version(3, 10));
 	else
 		return check_version(Version(4, 20));
@@ -659,9 +695,7 @@ bool QualifierConverter::supports_binding() const
 
 bool QualifierConverter::supports_interface_block_location() const
 {
-	if(features.target_api==VULKAN)
-		return true;
-	else if(features.target_api==OPENGL_ES)
+	if(features.target_api==OPENGL_ES)
 		return check_version(Version(3, 20));
 	else if(check_version(Version(4, 40)))
 		return true;