X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fgeometry%2Fhypersphere.h;h=abdd1939508c2a717f5856fed975da0690226a0a;hb=313e10c1dcf5504789cc145166aece93d8141212;hp=01aee0e57b22e2791763077aecb3e3193ea35843;hpb=643aa7b2317f88463f66da11e595ebe0f6c9621d;p=libs%2Fmath.git

diff --git a/source/geometry/hypersphere.h b/source/geometry/hypersphere.h
index 01aee0e..abdd193 100644
--- a/source/geometry/hypersphere.h
+++ b/source/geometry/hypersphere.h
@@ -2,6 +2,7 @@
 #define MSP_GEOMETRY_HYPERSPHERE_H_
 
 #include <cmath>
+#include <stdexcept>
 #include <msp/linal/vector.h>
 #include "hyperbox.h"
 #include "ray.h"
@@ -22,7 +23,7 @@ private:
 	T radius;
 
 public:
-	HyperSphere();
+	HyperSphere(): radius(1) { }
 	explicit HyperSphere(T);
 
 	virtual HyperSphere *clone() const;
@@ -31,20 +32,17 @@ public:
 
 	virtual HyperBox<T, D> get_axis_aligned_bounding_box() const;
 	virtual bool contains(const LinAl::Vector<T, D> &) const;
-	virtual bool check_intersection(const Ray<T, D> &) const;
 	virtual unsigned get_max_ray_intersections() const { return 2; }
 	virtual unsigned get_intersections(const Ray<T, D> &, SurfacePoint<T, D> *, unsigned) const;
 };
 
-template<typename T, unsigned D>
-inline HyperSphere<T, D>::HyperSphere():
-	radius(1)
-{ }
-
 template<typename T, unsigned D>
 inline HyperSphere<T, D>::HyperSphere(T r):
 	radius(r)
-{ }
+{
+	if(r<=T(0))
+		throw std::invalid_argument("HyperSphere::HyperShpere");
+}
 
 template<typename T, unsigned D>
 inline HyperSphere<T, D> *HyperSphere<T, D>::clone() const
@@ -67,16 +65,6 @@ inline bool HyperSphere<T, D>::contains(const LinAl::Vector<T, D> &point) const
 	return inner_product(point, point)<=radius*radius;
 }
 
-template<typename T, unsigned D>
-inline bool HyperSphere<T, D>::check_intersection(const Ray<T, D> &ray) const
-{
-	T x = inner_product(ray.get_direction(), ray.get_start());
-	if(x>0)
-		return contains(ray.get_start());
-	else
-		return contains(ray.get_start()-ray.get_direction()*x);
-}
-
 template<typename T, unsigned D>
 inline unsigned HyperSphere<T, D>::get_intersections(const Ray<T, D> &ray, SurfacePoint<T, D> *points, unsigned size) const
 {
@@ -90,10 +78,10 @@ inline unsigned HyperSphere<T, D>::get_intersections(const Ray<T, D> &ray, Surfa
 	T offset = sqrt(offset_sq);
 
 	unsigned n = 0;
-	for(int i=-1; i<=1; i+=2)
+	for(int i=-1; (n<size && i<=1); i+=2)
 	{
 		T x = mid+offset*i;
-		if(ray.check_limits(x) && n<size)
+		if(ray.check_limits(x))
 		{
 			if(points)
 			{
@@ -103,8 +91,6 @@ inline unsigned HyperSphere<T, D>::get_intersections(const Ray<T, D> &ray, Surfa
 			}
 
 			++n;
-			if(n==size)
-				return n;
 		}
 	}