X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fexternaltask.h;h=992df5c692a4c7bf8dfd6e6a208d2c64f15afdc0;hb=658c46ea8ef6d7022cb8c8e06565ebce12842d0b;hp=c9bc823112db7b3cb55eb7eeea043b2a94f140d1;hpb=47b06998f4f1c896928cee1911de3f7a43b283f4;p=builder.git

diff --git a/source/externaltask.h b/source/externaltask.h
index c9bc823..992df5c 100644
--- a/source/externaltask.h
+++ b/source/externaltask.h
@@ -3,26 +3,32 @@
 
 #include <string>
 #include <vector>
+#include <msp/core/process.h>
 #include <msp/fs/path.h>
 #include <msp/io/pipe.h>
 #include "task.h"
 
+/**
+Runs an external command.  A zero exit status is translated to a SUCCESS status
+for the task, and anything else is treated as an error.  Output can optionally
+be captured.
+*/
 class ExternalTask: public Task
 {
 public:
 	enum Destination
 	{
-		PASSTHROUGH,
-		CAPTURE,
-		IGNORE
+		PASSTHROUGH,  //< Do not touch the stream
+		CAPTURE,      //< Capture the stream
+		IGNORE        //< Redirect the stream to oblivion
 	};
 
-	typedef std::vector<std::string> Arguments;
+	typedef Msp::Process::Arguments Arguments;
 
 private:
 	Arguments argv;
 	Msp::FS::Path work_dir;
-	int pid;
+	Msp::Process *process;
 	int exit_code;
 	Destination stdout_dest;
 	Destination stderr_dest;
@@ -30,16 +36,34 @@ private:
 	std::string output;
 
 public:
-	ExternalTask(const Arguments &, const Msp::FS::Path &);
+	/** Creates an ExternalTask with an argument array and an optional working
+	directory.  The first element of the argument array should be the command
+	name.  If the working directory is not specified, no chdir is done. */
+	ExternalTask(const Arguments &, const Msp::FS::Path & = Msp::FS::Path());
+
 	virtual ~ExternalTask();
 
 	virtual std::string get_command() const;
 	virtual void start();
 	virtual Status check();
+	virtual Status wait();
+private:
+	Status do_wait(bool);
 
+public:
+	/// Sets destination for stdout.  Has no effect after the task is started.
 	void set_stdout(Destination);
+
+	/// Sets destination for stderr.  Has no effect after the task is started.
 	void set_stderr(Destination);
+
+	/** Returns captured output, if any.  This may be called while the task is
+	still running, but it will always return all output. */
 	const std::string &get_output() const { return output; }
+
+	/** Executes a command and captures its output.  Stderr is ignored, but if
+	the command exits with a nonzero status, an exception is thrown. */
+	static std::string run_and_capture_output(const Arguments &, const Msp::FS::Path & = Msp::FS::Path());
 };
 
 #endif