X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fexternalaction.cpp;h=97f6c619f426cb16e50cef20aa170e2008b86ea7;hb=b6dcf65b5e1b99f6c65454358c7610f3e9c8af2b;hp=81d28b37a6a7398fd0b186256c328a912ae87168;hpb=97001ddfa2463e6a3526eff772962acdad45f995;p=builder.git

diff --git a/source/externalaction.cpp b/source/externalaction.cpp
index 81d28b3..97f6c61 100644
--- a/source/externalaction.cpp
+++ b/source/externalaction.cpp
@@ -1,4 +1,5 @@
 #include <sys/wait.h>
+#include <iostream>
 #include <msp/iter.h>
 #include "builder.h"
 #include "externalaction.h"
@@ -8,27 +9,38 @@ using namespace Msp;
 
 int ExternalAction::check()
 {
+	if(builder.get_dry_run())
+	{
+		signal_done.emit();
+		return 0;
+	}
+	
 	if(!pid)
-		return 255;
+		return exit_code;
 
 	int status;
 	if(waitpid(pid, &status, WNOHANG)==pid)
 	{
 		signal_done.emit();
 		if(WIFEXITED(status))
-			return WEXITSTATUS(status);
+			exit_code=WEXITSTATUS(status);
 		else
-			return 254;
+			exit_code=254;
+		pid=0;
+		return exit_code;
 	}
 	else
 		return -1;
 }
 
+/**
+Starts the external program.  Fill in argv before calling this.
+*/
 void ExternalAction::launch()
 {
 	if(builder.get_verbose()>=2)
 	{
-		for(list<string>::const_iterator i=argv.begin(); i!=argv.end(); ++i)
+		for(StringList::const_iterator i=argv.begin(); i!=argv.end(); ++i)
 		{
 			if(i!=argv.begin())
 				cout<<' ';
@@ -37,16 +49,22 @@ void ExternalAction::launch()
 		cout<<'\n';
 	}
 	
-	pid=fork();
-	if(pid==0)
+	if(builder.get_dry_run())
+		pid=-1;
+	else
 	{
-		char *argv_[argv.size()+1];
-		for(CountingIterator<string, list<string>::iterator> i=argv.begin(); i!=argv.end(); ++i)
-			argv_[i.count()]=strdup(i->c_str());
-		argv_[argv.size()]=0;
-		execvp(argv_[0], argv_);
-		exit(1);
+		pid=fork();
+		if(pid==0)
+		{
+			char *argv_[argv.size()+1];
+			for(CountingIterator<string, StringList::iterator> i=argv.begin(); i!=argv.end(); ++i)
+				argv_[i.count()]=strdup(i->c_str());
+			argv_[argv.size()]=0;
+			execvp(argv_[0], argv_);
+			cout<<"Couldn't execute "<<argv.front()<<'\n';
+			exit(1);
+		}
+		else if(pid<0)
+			pid=0;
 	}
-	else if(pid<0)
-		pid=0;
 }