X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fexecutable.cpp;h=0cae259f8b7b755bf74da0913a516ecafbd7d09a;hb=1968c546cfb30214e8dc5afc722bec14aa8373f5;hp=db8bd11db0b3c832790d3cbdbef4d2f717ad80fd;hpb=b6dcf65b5e1b99f6c65454358c7610f3e9c8af2b;p=builder.git

diff --git a/source/executable.cpp b/source/executable.cpp
index db8bd11..0cae259 100644
--- a/source/executable.cpp
+++ b/source/executable.cpp
@@ -1,5 +1,12 @@
-#include <iostream>
-#include <msp/algo.h>
+/* $Id$
+
+This file is part of builder
+Copyright © 2006-2007 Mikko Rasa, Mikkosoft Productions
+Distributed under the LGPL
+*/
+
+#include <msp/path/utils.h>
+#include <msp/strings/formatter.h>
 #include "builder.h"
 #include "component.h"
 #include "executable.h"
@@ -26,8 +33,8 @@ Finds and adds any required libraries to the dependencies.
 */
 void Executable::find_depends()
 {
-	LibMode libmode=package->get_library_mode();
-	
+	LibMode libmode=comp.get_package().get_library_mode();
+
 	list<const Component *> queue;
 	list<Target *> dep_libs;
 	queue.push_back(&comp);
@@ -35,17 +42,17 @@ void Executable::find_depends()
 	{
 		const Component *c=queue.front();
 		queue.erase(queue.begin());
-		
+
+		const StringList &libpath=c->get_build_info().libpath;
+		const string &arch=c->get_package().get_arch();
+
 		const list<string> &libs=c->get_build_info().libs;
 		for(StringList::const_iterator i=libs.begin(); i!=libs.end(); ++i)
 		{
-			Target *lib=builder.get_library(*i, c->get_build_info().libpath, libmode);
+			Target *lib=builder.get_library(*i, arch, libpath, libmode);
 			if(lib)
 			{
-				if(contains(depends, lib))
-					continue;
-
-				dep_libs.push_front(lib);
+				dep_libs.push_back(lib);
 
 				if(dynamic_cast<Install *>(lib))
 					lib=lib->get_depends().front();
@@ -53,13 +60,20 @@ void Executable::find_depends()
 					queue.push_back(&stlib->get_component());
 			}
 			else
-				cout<<"Couldn't find library "<<*i<<" for "<<name<<'\n';
-				//XXX Throw an exception here or something
+				builder.problem(comp.get_package().get_name(), format("Couldn't find library %s for %s", *i, Path::basename(name)));
 		}
 	}
 
+	/* Add only the last occurrence of each library to the actual dependencies.
+	This ensures that static library ordering is correct. */
 	for(list<Target *>::iterator i=dep_libs.begin(); i!=dep_libs.end(); ++i)
-		add_depend(*i);
+	{
+		bool last=true;
+		for(list<Target *>::iterator j=i; (last && j!=dep_libs.end()); ++j)
+			last=(j==i || *j!=*i);
+		if(last)
+			add_depend(*i);
+	}
 
 	deps_ready=true;
 }
@@ -75,7 +89,7 @@ we need to pass the value to the Target c'tor.
 */
 string Executable::generate_target_name(const Component &c)
 {
-	string prefix,suffix;
+	string prefix, suffix;
 	const string &arch=c.get_package().get_arch();
 
 	if(c.get_type()==Component::LIBRARY)