X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fdatatool.cpp;h=75d52aaac8506d23007cd343acee69ce08ba122a;hb=bc6d4c540e7132c829dd558ca9d8acfbde7d71e1;hp=75ec2da7b750998d77395ba6ba57e8d77afd87a0;hpb=3f0f7216789aeedba206308c452623351e406e75;p=builder.git

diff --git a/source/datatool.cpp b/source/datatool.cpp
index 75ec2da..75d52aa 100644
--- a/source/datatool.cpp
+++ b/source/datatool.cpp
@@ -37,9 +37,11 @@ Target *DataTool::create_target(const list<Target *> &sources, const string &arg
 	}
 	else if(arg=="pack")
 	{
+		if(sources.empty())
+			throw invalid_argument("DataTool::create_target");
 		list<FileTarget *> files;
-		for(list<Target *>::const_iterator i=sources.begin(); i!=sources.end(); ++i)
-			files.push_back(&dynamic_cast<FileTarget &>(**i));
+		for(Target *t: sources)
+			files.push_back(&dynamic_cast<FileTarget &>(*t));
 		DataPack *pack = new DataPack(builder, *files.front()->get_component(), files);
 		pack->set_tool(*this);
 		return pack;
@@ -50,7 +52,9 @@ Target *DataTool::create_target(const list<Target *> &sources, const string &arg
 
 string DataTool::create_build_signature(const BuildInfo &binfo) const
 {
-	string result;
+	string result = Tool::create_build_signature(binfo);
+	if(binfo.debug || binfo.optimize)
+		result += ',';
 	if(binfo.debug)
 		result += 'g';
 	if(binfo.optimize>0)
@@ -92,9 +96,8 @@ Task *DataTool::run(const Target &tgt) const
 	else if(const DataPack *pack = dynamic_cast<const DataPack *>(&tgt))
 	{
 		argv.push_back("-p");
-		const DataPack::FileList &files = pack->get_files();
-		for(DataPack::FileList::const_iterator i=files.begin(); i!=files.end(); ++i)
-			argv.push_back(FS::relative((*i)->get_path(), work_dir).str());
+		for(const FileTarget *f: pack->get_files())
+			argv.push_back(FS::relative(f->get_path(), work_dir).str());
 	}
 
 	return new ExternalTask(argv, work_dir);