X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fcore%2Ftexture2d.cpp;h=31d7016574b17ecdf3200d587f781d940914d21e;hb=ada4b7614137221b64a00f31fde1498064e9fb19;hp=78f8c9e983034f34eadec903c5c53ffb4ffd6c5d;hpb=2b7f8e45e75bec30c1ea27fc0efd8286f67adc3f;p=libs%2Fgl.git

diff --git a/source/core/texture2d.cpp b/source/core/texture2d.cpp
index 78f8c9e9..31d70165 100644
--- a/source/core/texture2d.cpp
+++ b/source/core/texture2d.cpp
@@ -1,11 +1,9 @@
-#include <msp/core/raii.h>
 #include <msp/gl/extensions/arb_direct_state_access.h>
 #include <msp/gl/extensions/arb_texture_storage.h>
+#include <msp/gl/extensions/arb_vertex_buffer_object.h>
 #include <msp/graphics/imageloader.h>
-#include "bindable.h"
 #include "buffer.h"
 #include "error.h"
-#include "pixelstore.h"
 #include "resources.h"
 #include "texture2d.h"
 
@@ -38,8 +36,7 @@ public:
 Texture2D::Texture2D(ResourceManager *m):
 	Texture(GL_TEXTURE_2D, m),
 	width(0),
-	height(0),
-	allocated(0)
+	height(0)
 { }
 
 Texture2D::~Texture2D()
@@ -64,68 +61,38 @@ void Texture2D::storage(PixelFormat fmt, unsigned wd, unsigned ht, unsigned lv)
 	levels = get_n_levels();
 	if(lv>0)
 		levels = min(levels, lv);
-}
-
-void Texture2D::allocate(unsigned level)
-{
-	if(width==0 || height==0)
-		throw invalid_operation("Texture2D::allocate");
-	if(level>=levels)
-		throw invalid_argument("Texture2D::allocate");
-	if(allocated&(1<<level))
-		return;
 
+	GLenum gl_fmt = get_gl_pixelformat(storage_fmt);
 	if(ARB_texture_storage)
 	{
-		Conditional<BindRestore> _bind(!ARB_direct_state_access, this);
 		if(ARB_direct_state_access)
-			glTextureStorage2D(id, levels, storage_fmt, width, height);
+			glTextureStorage2D(id, levels, gl_fmt, width, height);
 		else
-			glTexStorage2D(target, levels, storage_fmt, width, height);
-		apply_swizzle();
-		allocated |= (1<<levels)-1;
+		{
+			bind_scratch();
+			glTexStorage2D(target, levels, gl_fmt, width, height);
+		}
 	}
 	else
-		image(level, 0);
-}
-
-void Texture2D::image(unsigned level, const void *data)
-{
-	if(width==0 || height==0)
-		throw invalid_operation("Texture2D::image");
-	if(level>=levels)
-		throw out_of_range("Texture2D::image");
-
-	LinAl::Vector<unsigned, 2> size = get_level_size(level);
-
-	if(ARB_texture_storage)
-		return sub_image(level, 0, 0, size.x, size.y, data);
-
-	BindRestore _bind(this);
-
-	if(!allocated)
 	{
+		bind_scratch();
 		glTexParameteri(target, GL_TEXTURE_MAX_LEVEL, levels-1);
-		apply_swizzle();
+		GLenum comp = get_gl_components(get_components(storage_fmt));
+		GLenum type = get_gl_type(get_component_type(storage_fmt));
+		for(unsigned i=0; i<levels; ++i)
+		{
+			LinAl::Vector<unsigned, 2> lv_size = get_level_size(i);
+			glTexImage2D(target, i, gl_fmt, lv_size.x, lv_size.y, 0, comp, type, 0);
+		}
 	}
 
-	PixelComponents comp = get_components(storage_fmt);
-	GLenum type = get_gl_type(get_component_type(storage_fmt));
-	glTexImage2D(target, level, storage_fmt, size.x, size.y, 0, comp, type, data);
-
-	allocated |= 1<<level;
-	if(auto_gen_mipmap && level==0)
-	{
-		generate_mipmap();
-		allocated |= (1<<levels)-1;
-	}
+	apply_swizzle();
 }
 
-void Texture2D::image(unsigned level, PixelComponents comp, DataType type, const void *data)
+void Texture2D::image(unsigned level, const void *data)
 {
-	if(comp!=get_components(format) || type!=get_component_type(format))
-		throw incompatible_data("Texture2D::image");
-	image(level, data);
+	LinAl::Vector<unsigned, 2> size = get_level_size(level);
+	return sub_image(level, 0, 0, size.x, size.y, data);
 }
 
 void Texture2D::sub_image(unsigned level, int x, int y, unsigned wd, unsigned ht, const void *data)
@@ -135,25 +102,15 @@ void Texture2D::sub_image(unsigned level, int x, int y, unsigned wd, unsigned ht
 	if(level>=levels)
 		throw out_of_range("Texture2D::sub_image");
 
-	Conditional<BindRestore> _bind(!ARB_direct_state_access, this);
-	allocate(level);
-
-	PixelComponents comp = get_components(storage_fmt);
+	GLenum comp = get_gl_components(get_components(storage_fmt));
 	GLenum type = get_gl_type(get_component_type(storage_fmt));
 	if(ARB_direct_state_access)
 		glTextureSubImage2D(id, level, x, y, wd, ht, comp, type, data);
 	else
+	{
+		bind_scratch();
 		glTexSubImage2D(target, level, x, y, wd, ht, comp, type, data);
-
-	if(auto_gen_mipmap && level==0)
-		generate_mipmap();
-}
-
-void Texture2D::sub_image(unsigned level, int x, int y, unsigned wd, unsigned ht, PixelComponents comp, DataType type, const void *data)
-{
-	if(comp!=get_components(format) || type!=get_component_type(format))
-		throw incompatible_data("Texture2D::sub_image");
-	sub_image(level, x, y, wd, ht, data);
+	}
 }
 
 void Texture2D::image(const Graphics::Image &img, unsigned lv)
@@ -168,9 +125,6 @@ void Texture2D::image(const Graphics::Image &img, unsigned lv, bool from_buffer)
 	PixelFormat fmt = pixelformat_from_image(img);
 	storage(make_pixelformat(get_components(fmt), get_component_type(fmt), use_srgb_format), w, h, lv);
 
-	PixelStore pstore = PixelStore::from_image(img);
-	BindRestore _bind_ps(pstore);
-
 	image(0, from_buffer ? 0 : img.get_pixels());
 }
 
@@ -200,7 +154,7 @@ Resource::AsyncLoader *Texture2D::load(IO::Seekable &io, const Resources *)
 	return ldr;
 }
 
-UInt64 Texture2D::get_data_size() const
+uint64_t Texture2D::get_data_size() const
 {
 	return id ? width*height*get_pixel_size(format) : 0;
 }
@@ -209,7 +163,6 @@ void Texture2D::unload()
 {
 	glDeleteTextures(1, &id);
 	id = 0;
-	allocated = 0;
 }
 
 
@@ -290,7 +243,6 @@ bool Texture2D::AsyncLoader::process()
 		image.load_into(*img_loader, mapped_address);
 	else if(phase==3)
 	{
-		Bind _bind_buf(pixel_buffer, PIXEL_UNPACK_BUFFER);
 		mapped_address = 0;
 		if(!pixel_buffer.unmap())
 		{
@@ -300,7 +252,11 @@ bool Texture2D::AsyncLoader::process()
 
 		if(!texture.id)
 			texture.generate_id();
+		glBindBuffer(GL_PIXEL_UNPACK_BUFFER, pixel_buffer.get_id());
 		texture.image(image, 0, true);
+		glBindBuffer(GL_PIXEL_UNPACK_BUFFER, 0);
+		if(texture.auto_gen_mipmap)
+			texture.generate_mipmap();
 	}
 
 	++phase;