X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fcore%2Fframeformat.h;h=669261ff6f49582b5e663d2d8fee756e3c329408;hb=3efe3bab1c8290bd49a957ebec0ad97e58a35fcf;hp=35d982ba8839f1489b75efab9489560a7aa2d6e3;hpb=3a1b9cbe2441ae670a97541dc8ccb0a2860c8302;p=libs%2Fgl.git

diff --git a/source/core/frameformat.h b/source/core/frameformat.h
index 35d982ba..669261ff 100644
--- a/source/core/frameformat.h
+++ b/source/core/frameformat.h
@@ -8,19 +8,22 @@ namespace Msp {
 namespace GL {
 
 /**
-Describes a single attachment of a framebuffer.  The values are bitfields laid
-as follows:
+Describes a single attachment of a framebuffer, including the type and index
+of the attachment point and the format of the attached texture.
 
-nnnn nn_f _sss _ccc
-      │ │    │    └╴Number of components
+The values are bitfields laid as follows:
+
+nnnn nn_f _sss rccc
+      │ │    │ │  └╴Number of components
+      │ │    │ └───╴Reverse order flag
       │ │    └─────╴Size of one component
       │ └──────────╴Floating-point flag
       └────────────╴Attachment index
 
 This information is presented for internal documentation purposes only; it is
-inadvisable for programs to rely on it.
+inadvisable for applications to rely on it.
 */
-enum FrameAttachment
+enum FrameAttachment: std::uint16_t
 {
 	COLOR_ATTACHMENT = 0x0014,
 	DEPTH_ATTACHMENT = 0xF941,
@@ -33,15 +36,16 @@ attachments (currently up to seven) as well as a sample count.
 */
 class FrameFormat
 {
-private:
-	enum { MAX_ATTACHMENTS = 7 };
+public:
+	static constexpr unsigned MAX_ATTACHMENTS = 7;
 
-	std::uint8_t count;
-	std::uint8_t samples;
-	std::uint16_t attachments[MAX_ATTACHMENTS];
+private:
+	std::uint8_t count = 0;
+	std::uint8_t samples = 0;
+	FrameAttachment attachments[MAX_ATTACHMENTS];
 
 public:
-	FrameFormat();
+	FrameFormat() = default;
 	FrameFormat(FrameAttachment);
 
 	FrameFormat operator,(FrameAttachment) const;
@@ -53,8 +57,8 @@ public:
 
 	unsigned size() const { return count; }
 	bool empty() const { return !count; }
-	const std::uint16_t *begin() const { return attachments; }
-	const std::uint16_t *end() const { return attachments+count; }
+	const FrameAttachment *begin() const { return attachments; }
+	const FrameAttachment *end() const { return attachments+count; }
 	int index(FrameAttachment) const;
 };
 
@@ -71,14 +75,14 @@ FrameAttachment make_indexed_attachment(FrameAttachment, unsigned);
 inline FrameAttachment operator,(FrameAttachment fa, unsigned i)
 { return make_indexed_attachment(fa, i); }
 
-inline unsigned get_attach_point(std::uint16_t fa)
+inline unsigned get_attach_point(FrameAttachment fa)
 { return fa>>10; }
 
-PixelFormat get_attachment_pixelformat(std::uint16_t);
-
-GLenum get_gl_attachment(FrameAttachment);
+PixelFormat get_attachment_pixelformat(FrameAttachment);
 
 } // namespace GL
 } // namespace Msp
 
+#include "frameformat_backend.h"
+
 #endif