X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fcomponent.cpp;h=db78917c70fdf63fe1aef7fb95fa599629ca34f9;hb=98ad5711a0c56d9783a0d22b932e9b55ddd30ba2;hp=feb5094b27a071fa8823eabd4e09c2fae466a11d;hpb=62ad932589407842cc1026af6e6d9f4012e60c67;p=builder.git

diff --git a/source/component.cpp b/source/component.cpp
index feb5094..db78917 100644
--- a/source/component.cpp
+++ b/source/component.cpp
@@ -68,6 +68,19 @@ void Component::create_build_info()
 	final_build_info.update_from(build_info);
 	build_info = final_build_info;
 
+	for(UseList::const_iterator i=uses.begin(); i!=uses.end(); ++i)
+	{
+		/* Select an include path that contains all the sources for this and the
+		used component.  This should produce a sensible result in most cases. */
+		FS::Path base;
+		for(SourceList::const_iterator j=sources.begin(); j!=sources.end(); ++j)
+			base = base.empty() ? *j : FS::common_ancestor(base, *j);
+		const SourceList &use_sources = (*i)->get_sources();
+		for(SourceList::const_iterator j=use_sources.begin(); j!=use_sources.end(); ++j)
+			base = FS::common_ancestor(base, *j);
+		build_info.incpath.push_back(base);
+	}
+
 	if(type==LIBRARY || type==MODULE)
 		if(build_info.libmode<BuildInfo::DYNAMIC)
 			build_info.libmode = BuildInfo::DYNAMIC;
@@ -88,7 +101,6 @@ void Component::create_targets() const
 	const Toolchain &toolchain = builder.get_toolchain();
 
 	SourceList source_filenames = collect_source_files();
-	list<Target *> inst_list;
 
 	string inst_loc;
 	if(type==TARBALL)
@@ -125,7 +137,8 @@ void Component::create_targets() const
 	}
 	else if(type==INSTALL)
 	{
-		inst_loc = name;
+		Target *inst = builder.get_target("install");
+		const Tool &copy = toolchain.get_tool("CP");
 		for(SourceList::const_iterator i=source_filenames.begin(); i!=source_filenames.end(); ++i)
 		{
 			FileTarget *ft;
@@ -133,7 +146,7 @@ void Component::create_targets() const
 				ft = dynamic_cast<FileTarget *>(tgt);
 			else
 				ft = new File(builder, package, *i);
-			inst_list.push_back(ft);
+			inst->add_dependency(*copy.create_target(*ft, name));
 		}
 	}
 	else if(type==DATAFILE)
@@ -149,7 +162,7 @@ void Component::create_targets() const
 
 		builder.add_primary_target(*result);
 		if(install)
-			inst_list.push_back(result);
+			builder.add_installed_target(*result);
 	}
 
 	if(type==PROGRAM || type==LIBRARY || type==MODULE)
@@ -172,7 +185,7 @@ void Component::create_targets() const
 				}
 
 				if(type==LIBRARY && install && dynamic_cast<FileTarget *>(src)->is_installable())
-					inst_list.push_back(src);
+					builder.add_installed_target(*src);
 			}
 		}
 
@@ -212,17 +225,9 @@ void Component::create_targets() const
 		{
 			builder.add_primary_target(**i);
 			if(install)
-				inst_list.push_back(*i);
+				builder.add_installed_target(**i);
 		}
 	}
-
-	Target *inst_tgt = builder.get_target("install");
-	const Tool &copy = toolchain.get_tool("CP");
-	for(list<Target *>::const_iterator i=inst_list.begin(); i!=inst_list.end(); ++i)
-	{
-		Target *inst = copy.create_target(**i, inst_loc);
-		inst_tgt->add_dependency(*inst);
-	}
 }
 
 Component::SourceList Component::collect_source_files() const
@@ -289,5 +294,5 @@ void Component::Loader::use(const string &n)
 			obj.uses.push_back(&*i);
 			return;
 		}
-	error(format("Unknown library component '%s'", n));
+	throw invalid_argument("Component::Loader::use");
 }