X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fcollection.h;h=f293428c8cdd0fc046019531335ccf6d28b525fc;hb=a02c84384a101c0dec48b6aa2dee53bac4bbd034;hp=85ca843f5e1aba552ab2c2ed26a7241d30675d0b;hpb=92644bf892df1220c8df67e1fc3da85dd02c53c5;p=libs%2Fdatafile.git

diff --git a/source/collection.h b/source/collection.h
index 85ca843..f293428 100644
--- a/source/collection.h
+++ b/source/collection.h
@@ -105,12 +105,15 @@ private:
 		virtual ~ItemCreatorBase() { }
 
 		template<typename S>
-		S *create(Collection &coll, const std::string &name)
+		bool create(Collection &coll, const std::string &name, S *&ptr)
 		{
 			ItemCreatorBridge<S> *creator=dynamic_cast<ItemCreatorBridge<S> *>(this);
 			if(creator)
-				return creator->create(coll, name);
-			return 0;
+			{
+				ptr=creator->create(coll, name);
+				return true;
+			}
+			return false;
 		}
 	};
 
@@ -189,7 +192,7 @@ public:
 	void add(const std::string &name, T *d)
 	{
 		if(items.count(name))
-			throw KeyError("Duplicate key '"+name+"' in collection");
+			throw KeyError("Duplicate key in collection", name);
 
 		items[name]=new Item<typename RemoveConst<T>::Type>(d);
 	}
@@ -198,19 +201,19 @@ public:
 	Gets an object of a specific type from the collection.
 	*/
 	template<typename T>
-	T &get(const std::string &name) const
+	T *get(const std::string &name) const
 	{
 		typedef typename RemoveConst<T>::Type NCT;
 
 		ItemMap::const_iterator i=items.find(name);
 		if(i==items.end())
-			throw KeyError("Item '"+name+"' not found in collection");
+			throw KeyError("Item not found in collection", name);
 
 		const Item<NCT> *item=dynamic_cast<const Item<NCT> *>(i->second);
 		if(!item)
-			throw TypeError("Item '"+name+"' is not of correct type");
+			throw TypeError("Type mismatch on item '"+name+"'");
 
-		return *item->data;
+		return item->data;
 	}
 
 	/**
@@ -219,7 +222,7 @@ public:
 	invoked.
 	*/
 	template<typename T>
-	T &get(const std::string &name)
+	T *get(const std::string &name)
 	{
 		typedef typename RemoveConst<T>::Type NCT;
 
@@ -227,20 +230,23 @@ public:
 		if(i==items.end())
 		{
 			for(ItemCreatorSeq::iterator j=creators.begin(); j!=creators.end(); ++j)
-				if(NCT *d=(*j)->create<NCT>(*this, name))
+			{
+				NCT *d=0;
+				if((*j)->create(*this, name, d))
 				{
 					// We already know that the item didn't exist yet
 					items[name]=new Item<NCT>(d);
-					return *d;
+					return d;
 				}
-			throw KeyError("Item '"+name+"' not found in collection");
+			}
+			throw KeyError("Item not found in collection", name);
 		}
 
 		const Item<NCT> *item=dynamic_cast<const Item<NCT> *>(i->second);
 		if(!item)
-			throw TypeError("Item '"+name+"' is not of correct type");
+			throw TypeError("Type mismatch on item '"+name+"'");
 
-		return *item->data;
+		return item->data;
 	}
 
 	/**
@@ -251,11 +257,26 @@ public:
 	{
 		std::list<std::string> result;
 		for(ItemMap::const_iterator i=items.begin(); i!=items.end(); ++i)
-			if(dynamic_cast<const Item<T> *>(i->second))
+			if(dynamic_cast<const Item<typename RemoveConst<T>::Type> *>(i->second))
 				result.push_back(i->first);
 		return result;
 	}
 
+	/**
+	Returns a list of objects of a specific type in the collection.
+	*/
+	template<typename T>
+	std::list<T *> get_list() const
+	{
+		typedef typename RemoveConst<T>::Type NCT;
+
+		std::list<T *> result;
+		for(ItemMap::const_iterator i=items.begin(); i!=items.end(); ++i)
+			if(Item<NCT> *item=dynamic_cast<Item<NCT> *>(i->second))
+				result.push_back(item->data);
+		return result;
+	}
+
 	/**
 	Checks whether a name exists in the collection.  Does not care about the
 	type of the object.