X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fcollection.h;h=d0e8a1a8bb9b25c636ab23a8c1e4bbdcfa5c04a7;hb=465ac6c7ceda80ce7e2f6e3f7b6901ce0921406e;hp=bc84d624b2948c4c9bb46eb1716581de22b8da62;hpb=a8a205c6a1780780ed7724cf1e401d94b23c898d;p=libs%2Fdatafile.git

diff --git a/source/collection.h b/source/collection.h
index bc84d62..d0e8a1a 100644
--- a/source/collection.h
+++ b/source/collection.h
@@ -19,6 +19,20 @@ class CollectionItemTypeBase;
 template<typename T>
 class CollectionItemType;
 
+template<typename T>
+class LoadableCollectionItemType;
+
+template<typename T, bool = HasLoader<T>::value>
+struct CollectionItemTypeChooser;
+
+template<typename T>
+struct CollectionItemTypeChooser<T, true>
+{ typedef LoadableCollectionItemType<T> Type; };
+
+template<typename T>
+struct CollectionItemTypeChooser<T, false>
+{ typedef CollectionItemType<T> Type; };
+
 /**
 A collection of objects that can be loaded from a datafile.  Each object is
 identified by a name, which must be unique across the entire collection.
@@ -44,7 +58,7 @@ public:
 	*/
 	class Loader: public DataFile::Loader
 	{
-		template<typename T> friend class CollectionItemType;
+		template<typename T> friend class LoadableCollectionItemType;
 
 	private:
 		Collection &coll;
@@ -69,8 +83,8 @@ public:
 
 private:
 	typedef std::map<std::string, Variant> ItemMap;
-	typedef std::list<CollectionItemTypeBase *> TypeList;
-	typedef std::list<const CollectionSource *> SourceList;
+	typedef std::vector<CollectionItemTypeBase *> TypeList;
+	typedef std::vector<const CollectionSource *> SourceList;
 
 	TypeList types;
 	ItemMap items;
@@ -128,18 +142,18 @@ private:
 	T &extract(const Variant &var) const;
 
 	template<typename T>
-	std::list<T *> extract_list(const std::list<const Variant *> &vars) const
+	std::list<T *> extract_list(const std::vector<const Variant *> &vars) const
 	{
 		std::list<T *> result;
-		for(std::list<const Variant *>::const_iterator i=vars.begin(); i!=vars.end(); ++i)
+		for(std::vector<const Variant *>::const_iterator i=vars.begin(); i!=vars.end(); ++i)
 			result.push_back(&extract<T>(**i));
 		return result;
 	}
 
-	void gather_items(std::list<const Variant *> *, std::list<std::string> *, const CollectionItemTypeBase &, bool) const;
+	void gather_items(std::vector<const Variant *> *, std::list<std::string> *, const CollectionItemTypeBase &, bool) const;
 
 	template<typename T>
-	void gather_items(std::list<const Variant *> *vars, std::list<std::string> *names, const CollectionItemTypeBase *type, bool include_sources) const
+	void gather_items(std::vector<const Variant *> *vars, std::list<std::string> *names, const CollectionItemTypeBase *type, bool include_sources) const
 	{
 		if(type || (type = get_type<T>()))
 			gather_items(vars, names, *type, include_sources);
@@ -171,7 +185,7 @@ public:
 	template<typename T>
 	std::list<T *> get_list() const
 	{
-		std::list<const Variant *> vars;
+		std::vector<const Variant *> vars;
 		gather_items<typename RemoveConst<T>::Type>(&vars, 0, 0, false);
 		return extract_list<T>(vars);
 	}
@@ -185,7 +199,7 @@ public:
 		if(type)
 			load_items_from_sources(*type);
 
-		std::list<const Variant *> vars;
+		std::vector<const Variant *> vars;
 		gather_items<typename RemoveConst<T>::Type>(&vars, 0, type, true);
 		return extract_list<T>(vars);
 	}
@@ -235,7 +249,12 @@ protected:
 	/** Adds a type to the collection.  The returned descriptor object reference
 	can be used to define how objects of that type can be loaded. */
 	template<typename T>
-	CollectionItemType<T> &add_type();
+	typename CollectionItemTypeChooser<T>::Type &add_type();
+
+	/** Returns a mutable reference to an existing type descriptor.  This can be
+	used to e.g. override the creator function of a type added by a base class. */
+	template<typename T>
+	typename CollectionItemTypeChooser<T>::Type &modify_type();
 
 private:
 	/** Returns the descriptor for a type, or null if one isn't defined.  An
@@ -318,9 +337,11 @@ protected:
 public:
 	virtual ~CollectionItemTypeBase();
 
+protected:
 	void set_keyword(const std::string &);
-	const std::string &get_keyword() const { return kwd; }
 	void add_suffix(const std::string &);
+public:
+	const std::string &get_keyword() const { return kwd; }
 	bool match_name(const std::string &) const;
 	virtual bool is_same_type(const CollectionItemTypeBase &) const = 0;
 	virtual bool check_item_type(const Variant &) const = 0;
@@ -443,8 +464,8 @@ public:
 	virtual bool check_item_type(const Variant &var) const
 	{ return var.check_type<RefPtr<T> >(); }
 
-	virtual void add_to_loader(Collection::Loader &loader) const
-	{ loader.add(kwd, &Collection::Loader::item<T, T>); }
+	virtual void add_to_loader(Collection::Loader &) const
+	{ }
 
 	virtual bool can_create() const
 	{ return creat!=0; }
@@ -458,6 +479,20 @@ public:
 			coll.add(name, obj);
 	}
 
+	virtual void load_item(Collection &, Parser &, const std::string &) const
+	{
+		throw std::runtime_error("this type cannot be loaded");
+	}
+};
+
+
+template<typename T>
+class LoadableCollectionItemType: public CollectionItemType<T>
+{
+public:
+	virtual void add_to_loader(Collection::Loader &loader) const
+	{ loader.add(this->kwd, &Collection::Loader::item<T, T>); }
+
 	virtual void load_item(Collection &coll, Parser &parser, const std::string &name) const
 	{
 		RefPtr<T> obj = new T;
@@ -481,13 +516,23 @@ T &Collection::extract(const Variant &var) const
 }
 
 template<typename T>
-CollectionItemType<T> &Collection::add_type()
+typename CollectionItemTypeChooser<T>::Type &Collection::add_type()
 {
-	CollectionItemType<T> *type = new CollectionItemType<T>;
+	typename CollectionItemTypeChooser<T>::Type *type = new typename CollectionItemTypeChooser<T>::Type;
 	types.push_back(type);
 	return *type;
 }
 
+template<typename T>
+typename CollectionItemTypeChooser<T>::Type &Collection::modify_type()
+{
+	for(TypeList::const_iterator j=types.begin(); j!=types.end(); ++j)
+		if(CollectionItemType<T> *t = dynamic_cast<CollectionItemType<T> *>(*j))
+			return *t;
+
+	throw std::logic_error("type not found in collection");
+}
+
 template<typename T>
 CollectionItemTypeBase *Collection::get_type(const std::string &name) const
 {