X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fcollection.h;h=39e6f43b2b3674b12c9d96e4de64f1fc1a2d4e49;hb=5520420ecb8da0f6528b2681569f7504f75ddf38;hp=06b8e348cbe3d2a7e16ce2735971802efa73a863;hpb=43b8dee0bf05dee1b4a07cc001fae0c81ec53a2f;p=libs%2Fdatafile.git

diff --git a/source/collection.h b/source/collection.h
index 06b8e34..39e6f43 100644
--- a/source/collection.h
+++ b/source/collection.h
@@ -2,10 +2,10 @@
 #define MSP_DATAFILE_COLLECTION_H_
 
 #include <msp/core/maputils.h>
-#include <msp/core/meta.h>
 #include <msp/core/refptr.h>
 #include "collectionsource.h"
 #include "loader.h"
+#include "meta.h"
 
 /* XXX This file is a big mess with too many things in it.  However, the
 dependencies between those things make it difficult to split up. */
@@ -13,20 +13,6 @@ dependencies between those things make it difficult to split up. */
 namespace Msp {
 namespace DataFile {
 
-/**
-Helper struct to determine whether a Loader has a Collection typedef.
-*/
-template<typename T>
-struct NeedsCollection: public Sfinae
-{
-	template<typename U>
-	static Yes f(typename U::Collection *);
-	template<typename U>
-	static No f(...);
-
-	enum { value = Evaluate<sizeof(f<T>(0))>::value };
-};
-
 class CollectionItemTypeBase;
 
 template<typename T>
@@ -131,7 +117,7 @@ public:
 	T &get(const std::string &name)
 	{
 		typedef typename RemoveConst<T>::Type NCT;
-		return extract<NCT>(get_var(name, get_type<NCT>()));
+		return extract<NCT>(get_var(name, get_type<NCT>(name)));
 	}
 
 private:
@@ -251,9 +237,10 @@ protected:
 	CollectionItemType<T> &add_type();
 
 private:
-	/// Returns the descriptor for a type, or null if one isn't defined.
+	/** Returns the descriptor for a type, or null if one isn't defined.  An
+	optional name can be given to prioritize matching types. */
 	template<typename T>
-	CollectionItemTypeBase *get_type() const;
+	CollectionItemTypeBase *get_type(const std::string & = std::string()) const;
 
 	/// Gets a descriptor with the same type as another descriptor.
 	CollectionItemTypeBase *get_type(const CollectionItemTypeBase &) const;
@@ -416,7 +403,7 @@ public:
 		return *this;
 	}
 
-	/** Adds a suffix that is used to match names when looking for future
+	/** Adds a suffix that is used to match names when looking for loadable
 	objects.  There is no implied separator; a name matches if it ends with the
 	suffix.  If a keyword is defined before any suffixes, then "."+keyword is
 	added as a suffix. */
@@ -500,15 +487,20 @@ CollectionItemType<T> &Collection::add_type()
 }
 
 template<typename T>
-CollectionItemTypeBase *Collection::get_type() const
+CollectionItemTypeBase *Collection::get_type(const std::string &name) const
 {
 	for(TypeList::const_iterator j=types.begin(); j!=types.end(); ++j)
 		if(dynamic_cast<CollectionItemType<T> *>(*j))
 			return *j;
+	CollectionItemTypeBase *type = 0;
 	for(TypeList::const_iterator j=types.begin(); j!=types.end(); ++j)
 		if((*j)->can_extract<T>())
-			return *j;
-	return 0;
+		{
+			if(!name.empty() && (*j)->match_name(name))
+				return *j;
+			type = *j;
+		}
+	return type;
 }
 
 } // namespace DataFile