X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fbatch.cpp;h=859a6ad5468f0783240d094075063d276764ac0f;hb=d886d08441f45448ba98166f7dd15d35baf24905;hp=bca33484ce976cc585d8da88187c8ba568baed23;hpb=c233a90fd05f1f5424d7fca94bb6b999f3061271;p=libs%2Fgl.git

diff --git a/source/batch.cpp b/source/batch.cpp
index bca33484..859a6ad5 100644
--- a/source/batch.cpp
+++ b/source/batch.cpp
@@ -1,4 +1,5 @@
 #include <msp/gl/extensions/ext_draw_range_elements.h>
+#include <msp/gl/extensions/msp_legacy_features.h>
 #include <msp/gl/extensions/nv_primitive_restart.h>
 #include "batch.h"
 #include "bindable.h"
@@ -59,9 +60,10 @@ Batch::Batch(PrimitiveType t):
 	max_index(0),
 	restart(false)
 {
-	/* XXX Should probably provide a fallback to glDrawElements since this class
-	is pretty much required to render anything. */
-	static Require _req(EXT_draw_range_elements);
+	/* Make sure we have glEnable/DisableClientState to go with
+	NV_primitive_restart */
+	if(NV_primitive_restart)
+		(bool)MSP_legacy_features;
 }
 
 Batch::~Batch()
@@ -122,7 +124,7 @@ bool Batch::can_append(PrimitiveType other_type)
 {
 	if(other_type!=prim_type)
 		return false;
-	else if(prim_type==LINE_STRIP || prim_type==LINE_LOOP || prim_type==TRIANGLE_FAN || prim_type==POLYGON)
+	else if(prim_type==LINE_STRIP || prim_type==LINE_LOOP || prim_type==TRIANGLE_FAN)
 		return NV_primitive_restart;
 	else
 		return true;
@@ -132,7 +134,7 @@ void Batch::append(const Batch &other)
 {
 	if(other.prim_type!=prim_type)
 		throw invalid_argument("Batch::append");
-	if(prim_type==LINE_STRIP || prim_type==LINE_LOOP || prim_type==TRIANGLE_FAN || prim_type==POLYGON)
+	if(prim_type==LINE_STRIP || prim_type==LINE_LOOP || prim_type==TRIANGLE_FAN)
 		static Require _req(NV_primitive_restart);
 
 	if(other.data.empty())
@@ -196,11 +198,6 @@ void Batch::append_index(unsigned i)
 		data.push_back(i);
 }
 
-void Batch::upload_data() const
-{
-	get_buffer()->sub_data(get_offset(), data.size(), &data[0]);
-}
-
 unsigned Batch::get_index_size() const
 {
 	if(data_type==UNSIGNED_SHORT)
@@ -246,30 +243,23 @@ void Batch::draw() const
 		restart_index = 0;
 	}
 
-	if(Buffer *ibuf = get_buffer())
+	Buffer *ibuf = get_buffer();
+	const void *data_ptr;
+	BindRestore _bind_ibuf(ibuf, ELEMENT_ARRAY_BUFFER);
+	if(ibuf)
 	{
-		bool have_vao = Mesh::current();
-		const Buffer *old_ibuf = 0;
-		if(!have_vao)
-		{
-			old_ibuf = Buffer::current(ELEMENT_ARRAY_BUFFER);
-			ibuf->bind_to(ELEMENT_ARRAY_BUFFER);
-		}
-
 		if(dirty)
 			update_buffer();
 
-		glDrawRangeElements(prim_type, min_index, max_index, size(), data_type, reinterpret_cast<void *>(get_offset()));
-		if(!have_vao)
-		{
-			if(old_ibuf)
-				old_ibuf->bind_to(ELEMENT_ARRAY_BUFFER);
-			else
-				Buffer::unbind_from(ELEMENT_ARRAY_BUFFER);
-		}
+		data_ptr = reinterpret_cast<const void *>(get_offset());
 	}
 	else
-		glDrawRangeElements(prim_type, min_index, max_index, size(), data_type, &data[0]);
+		data_ptr = &data[0];
+
+	if(EXT_draw_range_elements)
+		glDrawRangeElements(prim_type, min_index, max_index, size(), data_type, data_ptr);
+	else
+		glDrawElements(prim_type, size(), data_type, data_ptr);
 }