X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Fanimation.cpp;h=c0b508180b0da9f8676cd12e6f5c74a4a77cede1;hb=2b779717e42b514210f7128cf9aee2276650e003;hp=efb67c972ded72ad916c286def76bd34bf5de28c;hpb=164d77011ab4ebe76c9bf2b7ed8d8dd8ebc20e61;p=libs%2Fgl.git

diff --git a/source/animation.cpp b/source/animation.cpp
index efb67c97..c0b50818 100644
--- a/source/animation.cpp
+++ b/source/animation.cpp
@@ -3,6 +3,7 @@
 #include <msp/time/units.h>
 #include "animation.h"
 #include "armature.h"
+#include "error.h"
 #include "keyframe.h"
 #include "pose.h"
 
@@ -16,6 +17,10 @@ Animation::Animation():
 	looping(false)
 { }
 
+// Avoid synthesizing ~RefPtr in files including animation.h
+Animation::~Animation()
+{ }
+
 void Animation::set_armature(const Armature &a)
 {
 	armature = &a;
@@ -58,18 +63,17 @@ Animation::AxisInterpolation::AxisInterpolation(const double *axis1, const doubl
 {
 	// Compute a normalized vector halfway between the two endpoints
 	double half[3];
-	double len = 0;
+	double a1_len = 0;
+	double h_len = 0;
 	for(unsigned i=0; i<3; ++i)
 	{
 		half[i] = (axis1[i]+axis2[i])/2;
-		len += half[i]*half[i];
+		a1_len += axis1[i]*axis1[i];
+		h_len += half[i]*half[i];
 	}
-	len = sqrt(len);
-	for(unsigned i=0; i<3; ++i)
-		half[i] /= len;
 
 	// Compute correction factors for smooth interpolation
-	double cos_half = axis1[0]*half[0]+axis1[1]*half[1]+axis1[2]*half[2];
+	double cos_half = (axis1[0]*half[0]+axis1[1]*half[1]+axis1[2]*half[2])/sqrt(a1_len*h_len);
 	double angle = acos(cos_half);
 	slope = (angle ? angle/tan(angle) : 1);
 	scale = cos_half;
@@ -206,7 +210,7 @@ Matrix Animation::Iterator::get_matrix() const
 Matrix Animation::Iterator::get_pose_matrix(unsigned link) const
 {
 	if(!animation.armature)
-		throw logic_error("Animation::Iterator::get_pose_matrix");
+		throw invalid_operation("Animation::Iterator::get_pose_matrix");
 	if(link>animation.armature->get_max_link_index())
 		throw out_of_range("Animation::Iterator::get_pose_matrix");
 
@@ -219,10 +223,11 @@ Matrix Animation::Iterator::get_pose_matrix(unsigned link) const
 	}
 
 	// We must redo the base point correction since interpolation throws if off
+	// XXX This should probably be done on local matrices
 	Matrix result = iter->pose_matrices[link].get(time_since_keyframe/iter->delta_t);
 	const Vector3 &base = animation.armature->get_link(link).get_base();
 	Vector3 new_base = result*base;
-	result = Matrix::translation(base.x-new_base.x, base.y-new_base.y, base.z-new_base.z)*result;
+	result = Matrix::translation(base-new_base)*result;
 	return result;
 }