X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=dive.c;h=3fa09bd10c05982a9972c0db8a58a76314543f59;hb=549ad65bcb39e95c4deae0b77eb2476efa53df43;hp=b57205bc5ff096841cc0d0f3626265a650f9228f;hpb=a72408400c67a142b9abaec89df954df7dac7a71;p=ext%2Fsubsurface.git

diff --git a/dive.c b/dive.c
index b57205b..3fa09bd 100644
--- a/dive.c
+++ b/dive.c
@@ -26,6 +26,73 @@ void add_event(struct dive *dive, int time, int type, int flags, int value, cons
 	while (*p)
 		p = &(*p)->next;
 	*p = ev;
+	remember_event(name);
+}
+
+int get_pressure_units(unsigned int mb, const char **units)
+{
+	int pressure;
+	const char* unit;
+
+	switch (output_units.pressure) {
+	case PASCAL:
+		pressure = mb * 100;
+		unit = "pascal";
+		break;
+	case BAR:
+		pressure = (mb + 500) / 1000;
+		unit = "bar";
+		break;
+	case PSI:
+		pressure = mbar_to_PSI(mb);
+		unit = "psi";
+		break;
+	}
+	if (units)
+		*units = unit;
+	return pressure;
+}
+
+double get_temp_units(unsigned int mk, const char **units)
+{
+	double deg;
+	const char *unit;
+
+	if (output_units.temperature == FAHRENHEIT) {
+		deg = mkelvin_to_F(mk);
+		unit = UTF8_DEGREE "F";
+	} else {
+		deg = mkelvin_to_C(mk);
+		unit = UTF8_DEGREE "C";
+	}
+	if (units)
+		*units = unit;
+	return deg;
+}
+
+double get_volume_units(unsigned int ml, int *frac, const char **units)
+{
+	int decimals;
+	double vol;
+	const char *unit;
+
+	switch (output_units.volume) {
+	case LITER:
+		vol = ml / 1000.0;
+		unit = "l";
+		decimals = 1;
+		break;
+	case CUFT:
+		vol = ml_to_cuft(ml);
+		unit = "cuft";
+		decimals = 2;
+		break;
+	}
+	if (frac)
+		*frac = decimals;
+	if (units)
+		*units = unit;
+	return vol;
 }
 
 double get_depth_units(unsigned int mm, int *frac, const char **units)
@@ -140,64 +207,74 @@ static void update_temperature(temperature_t *temperature, int new)
 	}
 }
 
-/*
- * If you have more than 32 cylinders, you'd better have a 64-bit build.
- * And if you have more than 64 cylinders, you need to use another tool,
- * or fix this up to do something odd.
- */
-static unsigned long fixup_pressure(struct dive *dive, struct sample *sample, unsigned long flags)
+static void fixup_pressure(struct dive *dive, struct sample *sample)
 {
-	unsigned long mask;
 	unsigned int pressure, index;
 	cylinder_t *cyl;
 
 	pressure = sample->cylinderpressure.mbar;
 	if (!pressure)
-		return flags;
+		return;
 	index = sample->cylinderindex;
 	if (index >= MAX_CYLINDERS)
-		return flags;
+		return;
 	cyl = dive->cylinder + index;
-	if (!cyl->start.mbar)
-		cyl->start.mbar = pressure;
-	/*
-	 * If we already have an end pressure, without
-	 * ever having seen a sample for this cylinder,
-	 * that means that somebody set the end pressure
-	 * by hand
-	 */
-	mask = 1ul << index;
-	if (cyl->end.mbar) {
-		if (!(flags & mask))
-			return flags;
-	}
-	flags |= mask;
-
-	/* we need to handle the user entering beginning and end tank pressures
-	 * - maybe even IF we have samples. But for now if we have air pressure
-	 * data in the samples, we use that instead of the minimum
-	 * if (!cyl->end.mbar || pressure < cyl->end.mbar)
-	 */
-	cyl->end.mbar = pressure;
-	return flags;
+	if (!cyl->sample_start.mbar)
+		cyl->sample_start.mbar = pressure;
+	cyl->sample_end.mbar = pressure;
+}
+
+/*
+ * If the cylinder tank pressures are within half a bar
+ * (about 8 PSI) of the sample pressures, we consider it
+ * to be a rounding error, and throw them away as redundant.
+ */
+static int same_rounded_pressure(pressure_t a, pressure_t b)
+{
+	return abs(a.mbar - b.mbar) <= 500;
 }
 
 struct dive *fixup_dive(struct dive *dive)
 {
-	int i;
+	int i,j;
 	double depthtime = 0;
 	int lasttime = 0;
+	int lastindex = -1;
 	int start = -1, end = -1;
 	int maxdepth = 0, mintemp = 0;
 	int lastdepth = 0;
-	int lasttemp = 0;
-	unsigned long flags = 0;
+	int lasttemp = 0, lastpressure = 0;
+	int pressure_delta[MAX_CYLINDERS] = {INT_MAX, };
 
 	for (i = 0; i < dive->samples; i++) {
 		struct sample *sample = dive->sample + i;
 		int time = sample->time.seconds;
 		int depth = sample->depth.mm;
 		int temp = sample->temperature.mkelvin;
+		int pressure = sample->cylinderpressure.mbar;
+		int index = sample->cylinderindex;
+
+		if (index == lastindex) {
+			/* Remove duplicate redundant pressure information */
+			if (pressure == lastpressure)
+				sample->cylinderpressure.mbar = 0;
+			/* check for simply linear data in the samples
+			   +INT_MAX means uninitialized, -INT_MAX means not linear */
+			if (pressure_delta[index] != -INT_MAX && lastpressure) {
+				if (pressure_delta[index] == INT_MAX) {
+					pressure_delta[index] = abs(pressure - lastpressure);
+				} else {
+					int cur_delta = abs(pressure - lastpressure);
+					if (cur_delta && abs(cur_delta - pressure_delta[index]) > 150) {
+						/* ok the samples aren't just a linearisation
+						 * between start and end */
+						pressure_delta[index] = -INT_MAX;
+					}
+				}
+			}
+		}
+		lastindex = index;
+		lastpressure = pressure;
 
 		if (lastdepth)
 			end = time;
@@ -209,7 +286,7 @@ struct dive *fixup_dive(struct dive *dive)
 				maxdepth = depth;
 		}
 
-		flags = fixup_pressure(dive, sample, flags);
+		fixup_pressure(dive, sample);
 
 		if (temp) {
 			/*
@@ -229,6 +306,33 @@ struct dive *fixup_dive(struct dive *dive)
 		lastdepth = depth;
 		lasttime = time;
 	}
+	/* if all the samples for a cylinder have pressure data that
+	 * is basically equidistant throw out the sample cylinder pressure
+	 * information but make sure we still have a valid start and end
+	 * pressure
+	 * this happens when DivingLog decides to linearalize the
+	 * pressure between beginning and end and for strange reasons
+	 * decides to put that in the sample data as if it came from
+	 * the dive computer; we don't want that (we'll visualize with
+	 * constant SAC rate instead)
+	 * WARNING WARNING - I have only seen this in single tank dives
+	 * --- maybe I should try to create a multi tank dive and see what
+	 * --- divinglog does there - but the code right now is only tested
+	 * --- for the single tank case */
+	for (j = 0; j < MAX_CYLINDERS; j++) {
+		if (abs(pressure_delta[j]) != INT_MAX) {
+			cylinder_t *cyl = dive->cylinder + j;
+			for (i = 0; i < dive->samples; i++)
+				if (dive->sample[i].cylinderindex == j)
+					dive->sample[i].cylinderpressure.mbar = 0;
+			if (! cyl->start.mbar)
+				cyl->start.mbar = cyl->sample_start.mbar;
+			if (! cyl->end.mbar)
+				cyl->end.mbar = cyl->sample_end.mbar;
+			cyl->sample_start.mbar = 0;
+			cyl->sample_end.mbar = 0;
+		}
+	}
 	if (end < 0)
 		return dive;
 
@@ -244,8 +348,12 @@ struct dive *fixup_dive(struct dive *dive)
 	add_people(dive->divemaster);
 	add_location(dive->location);
 	for (i = 0; i < MAX_CYLINDERS; i++) {
-		cylinder_type_t *type = &dive->cylinder[i].type;
-		add_cylinder_description(type);
+		cylinder_t *cyl = dive->cylinder + i;
+		add_cylinder_description(&cyl->type);
+		if (same_rounded_pressure(cyl->sample_start, cyl->start))
+			cyl->start.mbar = 0;
+		if (same_rounded_pressure(cyl->sample_end, cyl->end))
+			cyl->end.mbar = 0;
 	}
 
 	return dive;
@@ -451,6 +559,7 @@ struct dive *try_to_merge(struct dive *a, struct dive *b)
 	MERGE_TXT(res, a, b, notes);
 	MERGE_TXT(res, a, b, buddy);
 	MERGE_TXT(res, a, b, divemaster);
+	MERGE_MAX(res, a, b, rating);
 	MERGE_MAX(res, a, b, number);
 	MERGE_MAX(res, a, b, maxdepth.mm);
 	res->meandepth.mm = 0;