X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;ds=sidebyside;f=source%2Ftime%2Ftimer.cpp;h=7c9567ecfecccafe826f8d1fcd52d0bb82d6f899;hb=ac26a7e3db27d27ea322ccc17bb093b348b30ae8;hp=59360b63fa6e18a83fed699429bf7e76a75d0b75;hpb=d16185720fa344263367dbd50c61bfc8183d99a4;p=libs%2Fcore.git

diff --git a/source/time/timer.cpp b/source/time/timer.cpp
index 59360b6..7c9567e 100644
--- a/source/time/timer.cpp
+++ b/source/time/timer.cpp
@@ -1,4 +1,5 @@
 #include <algorithm>
+#include <msp/core/raii.h>
 #include "timer.h"
 #include "utils.h"
 
@@ -7,6 +8,11 @@ using namespace std;
 namespace Msp {
 namespace Time {
 
+Timer::Timer():
+	sem(1),
+	blocking(false)
+{ }
+
 Timer::~Timer()
 {
 	for(vector<SlotProxy>::iterator i=slots.begin(); i!=slots.end(); ++i)
@@ -16,23 +22,22 @@ Timer::~Timer()
 Timer::Slot &Timer::add(const TimeDelta &td)
 {
 	Slot *s = new Slot(td);
-	mutex.lock();
+	MutexLock l(mutex);
 	slots.push_back(s);
 	push_heap(slots.begin(), slots.end());
-	mutex.unlock();
-	sem.signal();
+	if(blocking)
+		sem.signal();
 	return *s;
 }
 
 Timer::Slot &Timer::add(const TimeStamp &ts)
 {
 	Slot *s = new Slot(ts);
-	{
-		MutexLock l(mutex);
-		slots.push_back(s);
-		push_heap(slots.begin(), slots.end());
-	}
-	sem.signal();
+	MutexLock l(mutex);
+	slots.push_back(s);
+	push_heap(slots.begin(), slots.end());
+	if(blocking)
+		sem.signal();
 	return *s;
 }
 
@@ -56,21 +61,28 @@ void Timer::tick(bool block)
 		MutexLock l(mutex);
 		while(1)
 		{
-			if(slots.empty())
+			TimeStamp stamp;
+			TimeStamp t = now();
+			if(!slots.empty())
 			{
-				if(block)
-					sem.wait();
-				else
-					return;
+				next = slots.begin()->slot;
+				stamp = next->get_timeout();
+				if(stamp<=t)
+					break;
 			}
 
-			next = slots.begin()->slot;
-			const TimeStamp &stamp = next->get_timeout();
-			const TimeStamp t = now();
-			if(stamp<=t)
-				break;
-			else if(block)
-				sem.wait(stamp-t);
+			if(block)
+			{
+				SetFlag setf(blocking);
+				mutex.unlock();
+				if(stamp)
+					sem.wait(stamp-t);
+				else
+					sem.wait();
+				mutex.lock();
+				// The slots may have changed while waiting so check again
+				continue;
+			}
 			else
 				return;
 		}