X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;ds=sidebyside;f=source%2Ftexture3d.cpp;h=5e1f9866e185e6ecdb047f167a26ffa8054d03ea;hb=3c46227c280bc4cd8a4487c648f2f080d5b4f7ea;hp=36afa9bcdfe9b3fc2dc1e72c5ef8d19bce06f8aa;hpb=194f960f91041ebee44e2745627d5e480e893d82;p=libs%2Fgl.git

diff --git a/source/texture3d.cpp b/source/texture3d.cpp
index 36afa9bc..5e1f9866 100644
--- a/source/texture3d.cpp
+++ b/source/texture3d.cpp
@@ -1,6 +1,9 @@
 #include <cmath>
+#include <msp/core/raii.h>
+#include <msp/gl/extensions/arb_direct_state_access.h>
 #include <msp/gl/extensions/arb_texture_storage.h>
 #include <msp/gl/extensions/ext_texture3d.h>
+#include <msp/gl/extensions/ext_texture_array.h>
 #include <msp/graphics/image.h>
 #include "bindable.h"
 #include "error.h"
@@ -14,7 +17,6 @@ namespace GL {
 
 Texture3D::Texture3D(GLenum t):
 	Texture(t),
-	ifmt(RGB),
 	width(0),
 	height(0),
 	depth(0),
@@ -23,7 +25,6 @@ Texture3D::Texture3D(GLenum t):
 
 Texture3D::Texture3D():
 	Texture(GL_TEXTURE_3D),
-	ifmt(RGB),
 	width(0),
 	height(0),
 	depth(0),
@@ -39,11 +40,7 @@ void Texture3D::storage(PixelFormat fmt, unsigned wd, unsigned ht, unsigned dp)
 	if(wd==0 || ht==0 || dp==0)
 		throw invalid_argument("Texture3D::storage");
 
-	if(MSP_sized_internal_formats)
-		fmt = get_sized_pixelformat(fmt);
-	require_pixelformat(fmt);
-
-	ifmt = fmt;
+	set_internal_format(fmt);
 	width = wd;
 	height = ht;
 	depth = dp;
@@ -51,14 +48,21 @@ void Texture3D::storage(PixelFormat fmt, unsigned wd, unsigned ht, unsigned dp)
 
 void Texture3D::allocate(unsigned level)
 {
+	if(width==0 || height==0 || depth==0)
+		throw invalid_operation("Texture3D::allocate");
 	if(allocated&(1<<level))
 		return;
 
 	if(ARB_texture_storage)
 	{
-		BindRestore _bind(this);
 		unsigned n_levels = (is_mipmapped(min_filter) ? get_n_levels() : 1);
-		glTexStorage3D(target, n_levels, ifmt, width, height, depth);
+		if(ARB_direct_state_access)
+			glTextureStorage3D(id, n_levels, ifmt, width, height, depth);
+		else
+		{
+			BindRestore _bind(this);
+			glTexStorage3D(target, n_levels, ifmt, width, height, depth);
+		}
 		allocated |= (1<<n_levels)-1;
 	}
 	else
@@ -82,7 +86,7 @@ void Texture3D::image(unsigned level, PixelFormat fmt, DataType type, const void
 		return sub_image(level, 0, 0, 0, w, h, d, fmt, type, data);
 
 	BindRestore _bind(this);
-	glTexImage3D(target, level, ifmt, width, height, depth, 0, fmt, type, data);
+	glTexImage3D(target, level, ifmt, width, height, depth, 0, get_upload_format(fmt), type, data);
 
 	allocated |= 1<<level;
 	if(gen_mipmap && level==0)
@@ -97,10 +101,14 @@ void Texture3D::sub_image(unsigned level, int x, int y, int z, unsigned wd, unsi
 	if(width==0 || height==0 || depth==0)
 		throw invalid_operation("Texture3D::image");
 
-	BindRestore _bind(this);
+	Conditional<BindRestore> _bind(!ARB_direct_state_access, this);
 	allocate(level);
 
-	glTexSubImage3D(target, level, x, y, z, wd, ht, dp, fmt, type, data);
+	fmt = get_upload_format(fmt);
+	if(ARB_direct_state_access)
+		glTextureSubImage3D(id, level, x, y, z, wd, ht, dp, fmt, type, data);
+	else
+		glTexSubImage3D(target, level, x, y, z, wd, ht, dp, fmt, type, data);
 
 	if(gen_mipmap && level==0)
 		auto_generate_mipmap();