X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;ds=sidebyside;f=source%2Fbackends%2Fvulkan%2Fpipelinestate_backend.cpp;h=d14bc00c6539bb3c9509fab26abf4610cd151d1f;hb=f1e296bb2442dfbea12e7b38a97cc152aa34569c;hp=a6a548aff42b0bee36eb0ba751f7ad3419aad5f1;hpb=370eb9e6a1e54da52047ba843e25c36be9789209;p=libs%2Fgl.git

diff --git a/source/backends/vulkan/pipelinestate_backend.cpp b/source/backends/vulkan/pipelinestate_backend.cpp
index a6a548af..d14bc00c 100644
--- a/source/backends/vulkan/pipelinestate_backend.cpp
+++ b/source/backends/vulkan/pipelinestate_backend.cpp
@@ -41,6 +41,12 @@ void VulkanPipelineState::update() const
 	if(changes&PipelineState::VERTEX_SETUP)
 		self.vertex_setup->refresh();
 
+	if(changes&PipelineState::SHPROG)
+	{
+		push_const_compat = hash<32>(self.shprog->stage_flags);
+		push_const_compat = hash_update<32>(push_const_compat, self.shprog->get_push_constants_size());
+	}
+
 	constexpr unsigned pipeline_mask = PipelineState::SHPROG|PipelineState::VERTEX_SETUP|PipelineState::FACE_CULL|
 		PipelineState::DEPTH_TEST|PipelineState::STENCIL_TEST|PipelineState::BLEND|PipelineState::PRIMITIVE_TYPE;
 	if(changes&pipeline_mask)
@@ -77,9 +83,14 @@ void VulkanPipelineState::update() const
 		if(changed_sets)
 		{
 			descriptor_set_slots.resize(self.shprog->get_n_descriptor_sets());
+			first_changed_desc_set = descriptor_set_slots.size();
 			for(unsigned i=0; i<descriptor_set_slots.size(); ++i)
 				if(changed_sets&(1<<i))
+				{
 					descriptor_set_slots[i] = device.get_descriptor_pool().get_descriptor_set_slot(self, i);
+					first_changed_desc_set = min(first_changed_desc_set, i);
+				}
+
 			unapplied |= PipelineState::UNIFORMS;
 		}
 	}
@@ -261,6 +272,7 @@ uint64_t VulkanPipelineState::compute_descriptor_set_hash(unsigned index) const
 	const PipelineState &self = *static_cast<const PipelineState *>(this);
 
 	uint64_t result = hash<64>(0, 0);
+	bool empty = true;
 
 	auto i = lower_bound_member(self.uniform_blocks, static_cast<int>(index)<<20, &PipelineState::BoundUniformBlock::binding);
 	for(; (i!=self.uniform_blocks.end() && static_cast<unsigned>(i->binding)>>20==index); ++i)
@@ -269,6 +281,7 @@ uint64_t VulkanPipelineState::compute_descriptor_set_hash(unsigned index) const
 			result = hash_update<64>(result, i->binding);
 			result = hash_update<64>(result, reinterpret_cast<uintptr_t>(i->block));
 			result = hash_update<64>(result, reinterpret_cast<uintptr_t>(i->buffer->handle));
+			empty = false;
 		}
 
 	auto j = lower_bound_member(self.textures, index<<20, &PipelineState::BoundTexture::binding);
@@ -279,8 +292,12 @@ uint64_t VulkanPipelineState::compute_descriptor_set_hash(unsigned index) const
 			result = hash_update<64>(result, reinterpret_cast<uintptr_t>(j->texture->handle));
 			result = hash_update<64>(result, reinterpret_cast<uintptr_t>(j->sampler->handle));
 			result = hash_update<64>(result, j->level);
+			empty = false;
 		}
 
+	if(!empty)
+		result = hash_update<64>(result, self.shprog->stage_flags);
+
 	return result;
 }
 
@@ -375,18 +392,29 @@ void VulkanPipelineState::apply(VkCommandBuffer command_buffer, const VulkanPipe
 	const VulkanFunctions &vk = device.get_functions();
 
 	if(!last)
+	{
 		unapplied = ~0U;
+		first_changed_desc_set = 0;
+	}
 	else if(last!=this)
 	{
 		const PipelineState &last_ps = *static_cast<const PipelineState *>(last);
 		if(handle!=last->handle)
+		{
 			unapplied |= PipelineState::SHPROG;
+			if(self.push_const_compat!=last_ps.push_const_compat)
+			{
+				unapplied |= PipelineState::UNIFORMS;
+				first_changed_desc_set = 0;
+			}
+		}
 		if(self.vertex_setup!=last_ps.vertex_setup)
 			unapplied |= PipelineState::VERTEX_SETUP;
-		for(unsigned i=0; (i<descriptor_set_slots.size() && i<last->descriptor_set_slots.size()); ++i)
-			if(descriptor_set_slots[i]!=last->descriptor_set_slots[i])
+		for(unsigned i=0; i<descriptor_set_slots.size(); ++i)
+			if(i>=last->descriptor_set_slots.size() || descriptor_set_slots[i]!=last->descriptor_set_slots[i])
 			{
 				unapplied |= PipelineState::UNIFORMS;
+				first_changed_desc_set = min(first_changed_desc_set, i);
 				break;
 			}
 		if(self.viewport!=last_ps.viewport)
@@ -420,12 +448,13 @@ void VulkanPipelineState::apply(VkCommandBuffer command_buffer, const VulkanPipe
 	if((unapplied&PipelineState::UNIFORMS) && !descriptor_set_slots.empty())
 	{
 		vector<VkDescriptorSet> descriptor_set_handles;
-		descriptor_set_handles.reserve(self.descriptor_set_slots.size());
-		for(unsigned i=0; i<self.descriptor_set_slots.size(); ++i)
-			descriptor_set_handles.push_back(device.get_descriptor_pool().get_descriptor_set(self.descriptor_set_slots[i], self, i, frame));
+		descriptor_set_handles.reserve(descriptor_set_slots.size()-first_changed_desc_set);
+		for(unsigned i=first_changed_desc_set; i<descriptor_set_slots.size(); ++i)
+			descriptor_set_handles.push_back(device.get_descriptor_pool().get_descriptor_set(
+				self.descriptor_set_slots[i], self, i, frame));
 
 		vk.CmdBindDescriptorSets(command_buffer, VK_PIPELINE_BIND_POINT_GRAPHICS, self.shprog->layout_handle,
-			0, descriptor_set_handles.size(), descriptor_set_handles.data(), 0, 0);
+			first_changed_desc_set, descriptor_set_handles.size(), descriptor_set_handles.data(), 0, 0);
 	}
 
 	if(unapplied&(PipelineState::VIEWPORT|PipelineState::SCISSOR))
@@ -463,6 +492,7 @@ void VulkanPipelineState::apply(VkCommandBuffer command_buffer, const VulkanPipe
 	}
 
 	unapplied = 0;
+	first_changed_desc_set = descriptor_set_slots.size();
 }
 
 } // namespace GL