Add a sanity check for derived tool commands

[builder.git] / source / tool.cpp

diff --git a/source/tool.cpp b/source/tool.cpp
index 402d20d0b8722ae09d09e15af9eec27955180cae..eaf4977d8c16030f2aa1bb0994ad3abc1d67c900 100644 (file)
--- a/source/tool.cpp
+++ b/source/tool.cpp
@@ -43,50 +43,34 @@ void Tool::prepare()
                return;
 
        prepared = true;
-       do_prepare();
-       if(!executable && !command.empty())
-       {
+
+       if(!command.empty())
                executable = builder.get_vfs().find_binary(command);
-               if(!executable)
-               {
-                       builder.get_logger().log("problems", "Can't find executable %s for %s", command, tag);
-                       problems.push_back(format("Can't find executable %s", command));
-               }
+       prepare(*this);
+       if(!command.empty() && !executable)
+       {
+               builder.get_logger().log("problems", "Can't find executable %s for %s", command, tag);
+               problems.push_back(format("Can't find executable %s", command));
        }
 }
 
-string Tool::create_build_signature(const BuildInfo &) const
-{
-       if(executable)
-               return format("%s=%s", tag, FS::basename(executable->get_path()));
-       else
-               return string();
-}
-
-
-Target *SubTool::create_source(const Component &c, const FS::Path &p) const
-{
-       return parent.create_source(c, p);
-}
-
-Target *SubTool::create_source(const FS::Path &p) const
+void Tool::prepare(Tool &tool) const
 {
-       return parent.create_source(p);
-}
+       if(&tool!=this && tool.get_base_tool()!=this)
+               throw invalid_argument("Tool::prepare");
 
-Target *SubTool::create_target(const vector<Target *> &s, const string &a)
-{
-       return parent.create_target(s, a);
-}
+       if(&tool!=this && !command.empty() && tool.command.empty())
+               throw logic_error("Derived tool has no command");
 
-Target *SubTool::create_install(Target &t) const
-{
-       return parent.create_install(t);
+       do_prepare(tool);
 }
 
-string SubTool::create_build_signature(const BuildInfo &bi) const
+string Tool::create_build_signature(const BuildInfo &) const
 {
-       return parent.create_build_signature(bi);
+       if(executable)
+               return format("%s=%s", tag, FS::basename(executable->get_path()));
+       else
+               return string();
 }