Refactor the constructor of SourcePackage::Loader

[builder.git] / source / tool.cpp

diff --git a/source/tool.cpp b/source/tool.cpp
index f3a29905b1651f12cc2c4dc92ef95f55e38b5a0d..44255a1eb5ca692fe1fc03461cd63e4d422eca61 100644 (file)
--- a/source/tool.cpp
+++ b/source/tool.cpp
@@ -1,4 +1,4 @@
-#include <algorithm>
+#include <msp/core/algorithm.h>
 #include <msp/strings/format.h>
 #include "architecture.h"
 #include "builder.h"
@@ -38,12 +38,7 @@ void Tool::set_command(const string &cmd, bool cross)
 
 bool Tool::accepts_suffix(const string &suffix, bool aux) const
 {
-       if(find(input_suffixes.begin(), input_suffixes.end(), suffix)!=input_suffixes.end())
-               return true;
-       else if(aux)
-               return find(aux_suffixes.begin(), aux_suffixes.end(), suffix)!=aux_suffixes.end();
-       else
-               return false;
+       return (any_equals(input_suffixes, suffix) || (aux && any_equals(aux_suffixes, suffix)));
 }
 
 Target *Tool::create_target(Target &source, const string &arg)
@@ -64,7 +59,10 @@ void Tool::prepare()
        {
                executable = builder.get_vfs().find_binary(command);
                if(!executable)
+               {
+                       builder.get_logger().log("problems", format("Can't find executable %s for %s", command, tag));
                        problems.push_back(format("Can't find executable %s", command));
+               }
        }
 }