Further changes for library compatibility

[builder.git] / source / target.cpp

diff --git a/source/target.cpp b/source/target.cpp
index 38eaab59708440fb3d70bd3761ac4e793e53f321..bfb78672afb08e4e787236452b831b060a78632e 100644 (file)
--- a/source/target.cpp
+++ b/source/target.cpp
@@ -7,12 +7,10 @@ Distributed under the LGPL
 
 #include <msp/fs/stat.h>
 #include <msp/fs/utils.h>
-#include <msp/time/utils.h>
 #include "action.h"
 #include "builder.h"
 #include "filetarget.h"
 #include "package.h"
-#include "sourcepackage.h"
 #include "target.h"
 
 using namespace std;
@@ -26,25 +24,23 @@ Target::Target(Builder &b, const Package *p, const string &n):
        building(false),
        rebuild(false),
        deps_ready(false),
-       prepared(false),
-       counted(false)
-{
-       builder.add_target(this);
-}
+       preparing(false),
+       prepared(false)
+{ }
 
 Target *Target::get_buildable_target()
 {
        if(!rebuild)
                return 0;
 
-       bool self_ok=!building;
+       bool self_ok = !building;
        for(TargetList::iterator i=depends.begin(); i!=depends.end(); ++i)
        {
-               Target *tgt=(*i)->get_buildable_target();
+               Target *tgt = (*i)->get_buildable_target();
                if(tgt)
                        return tgt;
                else if((*i)->get_rebuild())
-                       self_ok=false;
+                       self_ok = false;
        }
 
        if(self_ok)
@@ -56,97 +52,61 @@ Target *Target::get_buildable_target()
 void Target::add_depend(Target *dep)
 {
        if(dep==this)
-               throw InvalidParameterValue("A target can't depend on itself");
+               throw invalid_argument("Target::add_depend");
        depends.push_back(dep);
-       dep->rdepends.push_back(this);
 }
 
 void Target::prepare()
 {
        if(prepared)
                return;
+       if(preparing)
+       {
+               builder.problem((package ? package->get_name() : string()), "Dependency cycle detected at "+name);
+               return;
+       }
 
-       prepared=true;
+       preparing = true;
        for(TargetList::iterator i=depends.begin(); i!=depends.end(); ++i)
                (*i)->prepare();
 
        check_rebuild();
-
+       preparing = false;
+       prepared = true;
 }
 
 Action *Target::build()
 {
        if(!buildable)
        {
-               rebuild=false;
+               rebuild = false;
                return 0;
        }
 
-       if(FileTarget *ft=dynamic_cast<FileTarget *>(this))
+       // XXX Minor breach of OO here
+       if(FileTarget *ft = dynamic_cast<FileTarget *>(this))
                if(!builder.get_dry_run() && FS::exists(ft->get_path()))
                        FS::unlink(ft->get_path());
 
-       Action *action=create_action();
+       Action *action = create_action();
        if(action)
        {
                action->signal_done.connect(sigc::mem_fun(this, &Target::build_done));
 
-               building=true;
+               building = true;
        }
 
        return action;
 }
 
-unsigned Target::count_rebuild()
-{
-       if(counted)
-               return 0;
-
-       counted=true;
-       unsigned count=rebuild;
-       for(TargetList::iterator i=depends.begin(); i!=depends.end(); ++i)
-               count+=(*i)->count_rebuild();
-       return count;
-}
-
-void Target::touch()
-{
-       mtime=Time::now();
-}
-
 void Target::mark_rebuild(const std::string &reason)
 {
-       rebuild=true;
-       rebuild_reason=reason;
-}
-
-void Target::check_rebuild()
-{
-       if(!buildable)
-               return;
-
-       if(builder.get_build_all())
-               mark_rebuild("Rebuilding everything");
-       else if(!mtime)
-               mark_rebuild("Does not exist");
-       else
-       {
-               for(TargetList::iterator i=depends.begin(); (i!=depends.end() && !rebuild); ++i)
-               {
-                       if((*i)->get_mtime()>mtime)
-                               mark_rebuild(FS::basename((*i)->get_name())+" has changed");
-                       else if((*i)->get_rebuild())
-                               mark_rebuild(FS::basename((*i)->get_name())+" needs rebuilding");
-               }
-       }
-
-       const SourcePackage *spkg=dynamic_cast<const SourcePackage *>(package);
-       if(!rebuild && spkg && spkg->get_config().get_mtime()>mtime)
-               mark_rebuild("Package options changed");
+       rebuild = true;
+       rebuild_reason = reason;
 }
 
 void Target::build_done()
 {
-       building=false;
-       rebuild=false;
+       building = false;
+       rebuild = false;
 }