]> git.tdb.fi Git - builder.git/blobdiff - source/target.cpp
Make Target::add_depend take a reference since null is not allowed
[builder.git] / source / target.cpp
index 2d4a2de034f45a49186792dcb7a64d8919fe24b6..577438b3528dce736aa3c22077e0857a24f5a0b4 100644 (file)
@@ -55,13 +55,13 @@ void Target::force_rebuild()
        mark_rebuild("Forced rebuild");
 }
 
-void Target::add_depend(Target *dep)
+void Target::add_depend(Target &dep)
 {
-       if(dep==this)
+       if(&dep==this)
                throw invalid_argument("Target::add_depend");
-       depends.push_back(dep);
+       depends.push_back(&dep);
        if(state>PREPARING)
-               dep->signal_bubble_rebuild.connect(sigc::mem_fun(this, &Target::check_rebuild));
+               dep.signal_bubble_rebuild.connect(sigc::mem_fun(this, &Target::check_rebuild));
 }
 
 void Target::prepare()
@@ -79,7 +79,7 @@ void Target::prepare()
        if(tool)
        {
                if(FileTarget *tool_exe = tool->get_executable())
-                       add_depend(tool_exe);
+                       add_depend(*tool_exe);
        }
 
        for(Dependencies::iterator i=depends.begin(); i!=depends.end(); ++i)