Use std::unique_ptr for owning pointers

[libs/net.git] / source / net / protocol.cpp

diff --git a/source/net/protocol.cpp b/source/net/protocol.cpp
index cee18367b7cb254abf220e33eaad1f76958679f0..402b84a0633cdeb4dbe45c463e2f9676af911709 100644 (file)
--- a/source/net/protocol.cpp
+++ b/source/net/protocol.cpp
@@ -15,13 +15,7 @@ Protocol::Protocol(unsigned npi):
        next_packet_id(npi)
 {
        PacketDefBuilder<PacketHeader, Serializer<PacketHeader>>(*this, header_def, Serializer<PacketHeader>())
-               (&PacketHeader::type)(&PacketHeader::length);
-}
-
-Protocol::~Protocol()
-{
-       for(auto &kvp: packet_class_defs)
-               delete kvp.second;
+               .fields(&PacketHeader::type, &PacketHeader::length);
 }
 
 unsigned Protocol::get_next_packet_class_id()
@@ -30,17 +24,14 @@ unsigned Protocol::get_next_packet_class_id()
        return next_id++;
 }
 
-void Protocol::add_packet(PacketDefBase *pdef)
+void Protocol::add_packet(unique_ptr<PacketDefBase> pdef)
 {
-       PacketDefBase *&ptr = packet_class_defs[pdef->get_class_id()];
+       unique_ptr<PacketDefBase> &ptr = packet_class_defs[pdef->get_class_id()];
        if(ptr)
-       {
                packet_id_defs.erase(ptr->get_id());
-               delete ptr;
-       }
-       ptr = pdef;
-       if(unsigned id = pdef->get_id())
-               packet_id_defs[id] = pdef;
+       ptr = move(pdef);
+       if(unsigned id = ptr->get_id())
+               packet_id_defs[id] = ptr.get();
 }
 
 const Protocol::PacketDefBase &Protocol::get_packet_by_class_id(unsigned id) const
@@ -56,11 +47,11 @@ const Protocol::PacketDefBase &Protocol::get_packet_by_id(unsigned id) const
 size_t Protocol::dispatch(ReceiverBase &rcv, const char *buf, size_t size) const
 {
        PacketHeader header;
-       buf = header_def.deserialize(header, buf, buf+size);
+       const char *ptr = header_def.deserialize(header, buf, buf+size);
        if(header.length>size)
                throw bad_packet("truncated");
        const PacketDefBase &pdef = get_packet_by_id(header.type);
-       const char *ptr = pdef.dispatch(rcv, buf, buf+header.length);
+       ptr = pdef.dispatch(rcv, ptr, ptr+header.length);
        return ptr-buf;
 }