Improve metrics_stale flag handling

[r2c2.git] / source / libr2c2 / trainrouter.cpp

diff --git a/source/libr2c2/trainrouter.cpp b/source/libr2c2/trainrouter.cpp
index 13b2970883535f99a9869939f83e32ab81ace7e0..cef98eebbe46c3a5793579b168d970e4e6734957 100644 (file)
--- a/source/libr2c2/trainrouter.cpp
+++ b/source/libr2c2/trainrouter.cpp
@@ -79,7 +79,7 @@ void TrainRouter::route_changed()
                TrackIter track = train.get_block_allocator().first().track_iter();
                for(; track; track=track.next())
                {
-                       if(!advance_to_track(reserving_route, *track))
+                       if(!advance_to_track(reserving_route, track))
                        {
                                already_at_end = true;
                                break;
@@ -307,7 +307,7 @@ void TrainRouter::block_reserved(Block &block, Train *t)
                track = t->get_block_allocator().first().track_iter();
                for(; track; track=track.next())
                {
-                       if(!advance_to_track(reserving_route, *track))
+                       if(!advance_to_track(reserving_route, track))
                                throw logic_error("internal error (reservation outside of route)");
                        else if(&track->get_block()==&block)
                                break;
@@ -318,7 +318,7 @@ void TrainRouter::block_reserved(Block &block, Train *t)
        expected to be allocated next. */
        for(; track; track=track.next((*reserving_route)->get_path(*track)))
        {
-               if(!advance_to_track(reserving_route, *track))
+               if(!advance_to_track(reserving_route, track))
                {
                        // We've reached the end of the route.  Stop here.
                        arrival = RESERVED_TO_END;
@@ -354,6 +354,7 @@ void TrainRouter::train_advanced(Block &block)
                                if(!wp.has_track(*t_iter))
                                {
                                        waypoints.erase(waypoints.begin());
+                                       metrics_stale = true;
                                        signal_waypoint_reached.emit(&wp);
                                        signal_event.emit(Message("waypoint-reached", &wp));
                                        break;
@@ -390,6 +391,8 @@ void TrainRouter::create_metrics()
                delete *i;
        metrics.clear();
 
+       metrics_stale = false;
+
        if(!destination)
                return;
 
@@ -399,8 +402,6 @@ void TrainRouter::create_metrics()
 
        for(unsigned i=metrics.size(); --i>0; )
                metrics[i]->chain_to(*metrics[(i+1)%metrics.size()]);
-
-       metrics_stale = false;
 }
 
 bool TrainRouter::create_lead_route()
@@ -444,16 +445,16 @@ bool TrainRouter::create_lead_route()
        return true;
 }
 
-bool TrainRouter::is_valid_for_track(const Route &route, Track &track) const
+bool TrainRouter::is_valid_for_track(const Route &route, const TrackIter &track) const
 {
-       if(!route.has_track(track))
+       if(!route.has_track(*track))
                return false;
-       if(track.get_type().is_turnout() && route.get_turnout(track.get_turnout_address())<0)
+       if(track->get_type().is_turnout() && route.get_turnout(track->get_turnout_address())<0 && route.has_track(*track.flip()))
                return false;
        return true;
 }
 
-bool TrainRouter::advance_to_track(RouteList::iterator &route, Track &track)
+bool TrainRouter::advance_to_track(RouteList::iterator &route, const TrackIter &track)
 {
        if(!is_valid_for_track(**route, track))
        {