power(false),
halted(false),
active_accessory(0),
+ command_timeout(200*Time::msec),
s88(*this),
mfx_search(*this),
thread(*this)
if(acc.kind!=kind)
throw key_error(addr);
- if(state!=acc.target)
+ if(state!=acc.target || acc.uncertain)
{
acc.target = state;
accessory_queue.push_back(&acc);
{
if(acc.state.commit(tag.serial))
{
- if(acc.state==acc.target)
- {
- if(acc.kind==Accessory::TURNOUT)
- signal_turnout.emit(acc.address, acc.state);
- else if(acc.kind==Accessory::SIGNAL)
- signal_signal.emit(acc.address, acc.state);
- }
if(&acc==active_accessory)
active_accessory = 0;
}
}
}
- while(!active_accessory && !accessory_queue.empty())
+ while(power && !active_accessory && !accessory_queue.empty())
{
Accessory &acc = *accessory_queue.front();
- if(acc.state!=acc.target)
+ if(acc.state!=acc.target || acc.uncertain)
{
- active_accessory = &acc;
-
unsigned changes = acc.state^acc.target;
unsigned lowest_bit = changes&~(changes-1);
- unsigned i;
- for(i=0; (lowest_bit>>i)>1; ++i) ;
- active_index = i;
- acc.state.set(acc.state^lowest_bit);
- PendingCommand cmd(acc, Accessory::ACTIVATE, i);
- command_queue.push(cmd);
-
- monitor.reset_peak();
+ if(lowest_bit>>acc.bits)
+ {
+ // All remaining changes are in non-physical bits
+ acc.state.set(acc.state^changes);
+ acc.state.commit(acc.state.serial);
+ }
+ else
+ {
+ unsigned mask = (lowest_bit ? lowest_bit : acc.uncertain);
+ for(active_index=0; (mask>>active_index)>1; ++active_index) ;
+ acc.state.set(acc.state^lowest_bit);
+ PendingCommand cmd(acc, Accessory::ACTIVATE, active_index);
+ command_queue.push(cmd);
+ active_accessory = &acc;
+
+ monitor.reset_peak();
+ }
}
else
+ {
accessory_queue.pop_front();
+
+ if(acc.state==acc.target)
+ {
+ if(acc.kind==Accessory::TURNOUT)
+ signal_turnout.emit(acc.address, acc.state);
+ else if(acc.kind==Accessory::SIGNAL)
+ signal_signal.emit(acc.address, acc.state);
+ }
+ }
}
if(active_accessory && off_timeout)
{
Accessory &acc = *active_accessory;
- if(acc.kind==Accessory::TURNOUT && monitor.get_peak()<0.5f)
+ unsigned bit = 1<<active_index;
+
+ // Assume success if we were uncertain of the physical setting
+ if(acc.uncertain&bit)
+ acc.uncertain &= ~bit;
+ else if(acc.kind==Accessory::TURNOUT && monitor.get_peak()<0.5f)
{
- unsigned bit = 1<<active_index;
- if(acc.uncertain&bit)
- acc.uncertain &= ~bit;
- else
- {
- signal_turnout_failed.emit(acc.address);
- acc.state.rollback();
- acc.target ^= bit;
- }
+ signal_turnout_failed.emit(acc.address);
+ acc.state.rollback();
+ acc.target ^= bit;
}
off_timeout = Time::TimeStamp();
void ArduControl::flush()
{
+ while(!command_queue.empty() || (power && !accessory_queue.empty()))
+ tick();
}
void ArduControl::save_state() const
return true;
}
+template<typename T>
+bool ArduControl::Queue<T>::empty() const
+{
+ return items.empty();
+}
+
ArduControl::RefreshTask::RefreshTask():
next(cycle.end()),
if(get_work(cmd))
{
bool success = true;
+ bool resync = false;
for(unsigned i=0; (success && i<cmd.repeat_count); ++i)
- success = (do_command(cmd)==COMMAND_OK);
+ {
+ unsigned result = do_command(cmd, control.command_timeout);
+ success = (result==COMMAND_OK);
+ resync = (result==0);
+ }
+
if(success && cmd.tag)
control.completed_commands.push(cmd.tag);
+
+ if(resync)
+ {
+ if(control.debug>=1)
+ IO::print("Synchronization with ArduControl lost, attempting to recover\n");
+ for(unsigned i=0; (resync && i<16); ++i)
+ {
+ control.serial.put('\xFF');
+ while(IO::poll(control.serial, IO::P_INPUT, control.command_timeout))
+ resync = (control.serial.get()!=0xFF);
+ }
+ if(resync)
+ {
+ if(control.debug>=1)
+ IO::print("Resynchronization failed, giving up\n");
+ done = true;
+ }
+ else
+ {
+ if(control.debug>=1)
+ IO::print("Resynchronization successful\n");
+ if(cmd.tag)
+ control.command_queue.push(cmd);
+ }
+ }
}
else
Time::sleep(10*Time::msec);
cmd.command[1] = rates[0]>>8;
cmd.command[2] = rates[0];
cmd.length = 3;
- if(do_command(cmd)==COMMAND_OK)
+ if(do_command(cmd, Time::sec)==COMMAND_OK)
{
control.serial.set_baud_rate(rates[0]);
Time::sleep(Time::sec);
- if(do_command(cmd)==COMMAND_OK)
+ if(do_command(cmd, Time::sec)==COMMAND_OK)
{
if(control.debug>=1)
IO::print("Rate changed to %d bits/s\n", rates[0]);
return true;
}
-unsigned ArduControl::ControlThread::do_command(const PendingCommand &cmd)
+unsigned ArduControl::ControlThread::do_command(const PendingCommand &cmd, const Time::TimeDelta &timeout)
{
if(control.debug>=2)
{
if(result)
got_data = IO::poll(control.serial, IO::P_INPUT, Time::zero);
else
- got_data = IO::poll(control.serial, IO::P_INPUT);
+ got_data = IO::poll(control.serial, IO::P_INPUT, timeout);
if(!got_data)
break;
char reply[15];
unsigned pos = 0;
while(pos<rlength)
+ {
+ if(!IO::poll(control.serial, IO::P_INPUT, timeout))
+ return 0;
pos += control.serial.read(reply+pos, rlength-pos);
+ }
if(control.debug>=2)
{
return type;
}
else if(type==POWER_STATE && rlength==2)
+ set_power(reply[1]);
+ else if(type==OVERCURRENT)
{
- control.power.set(reply[1]);
-
- Tag tag;
- tag.type = Tag::GENERAL;
- tag.command = POWER;
- tag.serial = control.power.serial;
- control.completed_commands.push(tag);
+ set_power(false);
+ IO::print("Overcurrent detected!\n");
}
else
{
return 0;
}
+void ArduControl::ControlThread::set_power(bool p)
+{
+ control.power.set(p);
+
+ Tag tag;
+ tag.type = Tag::GENERAL;
+ tag.command = POWER;
+ tag.serial = control.power.serial;
+ control.completed_commands.push(tag);
+}
+
ArduControl::Loader::Loader(ArduControl &c):
DataFile::ObjectLoader<ArduControl>(c)