]> git.tdb.fi Git - builder.git/blobdiff - source/builder.cpp
Rework the Target class hierarchy
[builder.git] / source / builder.cpp
index 21e7dcdf629c4a97780059c5d1615cb12dca60b2..bbf6eb1d046dbf8fee32e4d2279de3d2ccaad329 100644 (file)
@@ -1,18 +1,22 @@
 /* $Id$
 
 This file is part of builder
-Copyright © 2006-2007 Mikko Rasa, Mikkosoft Productions
+Copyright © 2006-200 Mikko Rasa, Mikkosoft Productions
 Distributed under the LGPL
 */
 
 #include <iostream>
 #include <set>
+#include <sys/utsname.h>
 #include <msp/core/except.h>
 #include <msp/core/getopt.h>
 #include <msp/datafile/parser.h>
+#include <msp/fs/dir.h>
+#include <msp/fs/stat.h>
+#include <msp/fs/utils.h>
 #include <msp/io/buffered.h>
+#include <msp/io/except.h>
 #include <msp/io/file.h>
-#include <msp/path/utils.h>
 #include <msp/strings/formatter.h>
 #include <msp/strings/regex.h>
 #include <msp/strings/utils.h>
@@ -37,6 +41,17 @@ Distributed under the LGPL
 using namespace std;
 using namespace Msp;
 
+namespace {
+
+void update_hash(string &hash, const string &value)
+{
+       for(unsigned i=0; i<value.size(); ++i)
+               hash[i%hash.size()]^=value[i];
+}
+
+}
+
+
 Builder::Builder(int argc, char **argv):
        main_pkg(0),
        analyzer(0),
@@ -53,10 +68,13 @@ Builder::Builder(int argc, char **argv):
        build_all(false),
        create_makefile(false)
 {
-       string   analyze_mode;
-       string   work_dir;
-       bool     full_paths=false;
+       string analyze_mode;
+       string work_dir;
+       bool full_paths=false;
        unsigned max_depth=5;
+       StringList cmdline_warn;
+       string prfx;
+       string arch;
 
        GetOpt getopt;
        getopt.add_option('a', "analyze",    analyze_mode, GetOpt::REQUIRED_ARG);
@@ -72,10 +90,13 @@ Builder::Builder(int argc, char **argv):
        getopt.add_option('C', "chdir",      work_dir,     GetOpt::REQUIRED_ARG);
        getopt.add_option('P', "progress",   show_progress, GetOpt::NO_ARG);
        getopt.add_option('W', "what-if",    what_if,      GetOpt::REQUIRED_ARG);
+       getopt.add_option(     "arch",       arch,         GetOpt::REQUIRED_ARG);
        getopt.add_option(     "conf-only",  conf_only,    GetOpt::NO_ARG);
        getopt.add_option(     "full-paths", full_paths,   GetOpt::NO_ARG);
        //getopt.add_option(     "makefile",   create_makefile, GetOpt::NO_ARG);
        getopt.add_option(     "max-depth",  max_depth,    GetOpt::REQUIRED_ARG);
+       getopt.add_option(     "prefix",     prfx,         GetOpt::REQUIRED_ARG);
+       getopt.add_option(     "warnings",   cmdline_warn, GetOpt::REQUIRED_ARG);
        getopt(argc, argv);
 
        if(!analyze_mode.empty())
@@ -113,97 +134,184 @@ Builder::Builder(int argc, char **argv):
                cmdline_targets.push_back("default");
 
        if(!work_dir.empty())
-               chdir(work_dir.c_str());
+               FS::chdir(work_dir);
 
-       cwd=getcwd();
+       cwd=FS::getcwd();
 
-       Architecture &native_arch=archs.insert(ArchMap::value_type("native", Architecture(*this, "native"))).first->second;
-       native_arch.set_tool("CC",  "gcc");
-       native_arch.set_tool("CXX", "g++");
-       native_arch.set_tool("LD",  "gcc");
-       native_arch.set_tool("LXX", "g++");
-       native_arch.set_tool("AR",  "ar");
+       utsname un;
+       string sysname="native";
+       if(uname(&un)==0)
+               sysname=tolower(un.sysname);
 
-       const char *home=getenv("HOME");
-       if(home)
-               load_build_file((Path(home)/".builderrc").str());
-}
+       native_arch=&archs.insert(ArchMap::value_type(sysname, Architecture(*this, sysname, true))).first->second;
+       native_arch->set_tool("CC",  "gcc");
+       native_arch->set_tool("CXX", "g++");
+       native_arch->set_tool("LD",  "gcc");
+       native_arch->set_tool("LXX", "g++");
+       native_arch->set_tool("AR",  "ar");
 
-/**
-Gets a package with the specified name, possibly creating it.
+       load_build_file((FS::get_sys_data_dir(argv[0], "builder")/"builderrc").str());
+       load_build_file((FS::get_home_dir()/".builderrc").str());
 
-@param   n  Package name
+       if(arch.empty())
+               current_arch=native_arch;
+       else
+               current_arch=&get_architecture(arch);
 
-@return  Pointer to the package, or 0 if the package could not be located
-*/
-Package *Builder::get_package(const string &n)
+       if(prfx.empty())
+       {
+               if(current_arch->is_native())
+                       prefix=(FS::get_home_dir()/"local").str();
+               else
+                       prefix=(FS::get_home_dir()/"local"/current_arch->get_name()).str();
+       }
+       else
+               prefix=FS::getcwd()/prfx;
+
+       warnings.push_back("all");
+       warnings.push_back("extra");
+       warnings.push_back("shadow");
+       warnings.push_back("pointer-arith");
+       warnings.push_back("error");
+       for(StringList::iterator i=cmdline_warn.begin(); i!=cmdline_warn.end(); ++i)
+       {
+               vector<string> warns=split(*i, ',');
+               warnings.insert(warnings.end(), warns.begin(), warns.end());
+       }
+
+       pkg_path.push_back(cwd/".");
+       pkg_path.push_back(cwd/"..");
+}
+
+Builder::~Builder()
 {
-       PackageMap::iterator i=packages.find(n);
-       if(i!=packages.end())
-               return i->second;
+       for(PackageMap::iterator i=packages.begin(); i!=packages.end(); ++i)
+               delete i->second;
+       for(TargetMap::iterator i=targets.begin(); i!=targets.end(); ++i)
+               delete i->second;
+       delete analyzer;
+}
 
-       // Try to get source directory with pkgconfig
-       list<string> argv;
-       argv.push_back("pkg-config");
-       argv.push_back("--variable=source");
-       argv.push_back(n);
-       if(verbose>=4)
-               cout<<"Running "<<join(argv.begin(), argv.end())<<'\n';
-       string srcdir=strip(run_command(argv));
+int Builder::main()
+{
+       if(load_build_file(cwd/build_file))
+       {
+               cerr<<"No build info here.\n";
+               return 1;
+       }
 
-       PathList dirs;
-       if(!srcdir.empty())
-               dirs.push_back(srcdir);
-
-       // Make some other guesses about the source directory
-       string dirname=n;
-       if(!dirname.compare(0, 3, "msp"))
-               dirname.erase(0, 3);
-       dirs.push_back(cwd/dirname);
-       dirs.push_back(cwd/".."/dirname);
-
-       // Go through the candidate directories and look for a Build file
-       for(PathList::iterator j=dirs.begin(); j!=dirs.end(); ++j)
-               if(!load_build_file(*j/"Build"))
+       main_pkg->configure(cmdline_options, conf_all?2:1);
+
+       if(help)
+       {
+               usage(0, "builder", false);
+               cout<<'\n';
+               package_help();
+               return 0;
+       }
+
+       if(!conf_only && create_targets())
+               return 1;
+
+       PackageList all_reqs=main_pkg->collect_requires();
+
+       if(conf_only)
+               return 0;
+
+       if(verbose>=2)
+               cout<<"Building on "<<native_arch->get_name()<<", for "<<current_arch->get_name()<<'\n';
+       if(verbose>=1)
+               cout<<all_reqs.size()<<" active packages, "<<targets.size()<<" targets\n";
+       if(verbose>=2)
+       {
+               for(PackageList::const_iterator i=all_reqs.begin(); i!=all_reqs.end(); ++i)
                {
-                       i=packages.find(n);
-                       if(i!=packages.end())
-                               return i->second;
-                       break;
+                       cout<<' '<<(*i)->get_name();
+                       if(dynamic_cast<SourcePackage *>(*i))
+                               cout<<'*';
+                       unsigned count=0;
+                       unsigned ood_count=0;
+                       for(TargetMap::iterator j=targets.begin(); j!=targets.end(); ++j)
+                               if(j->second->get_package()==*i)
+                               {
+                                       ++count;
+                                       if(j->second->get_rebuild())
+                                               ++ood_count;
+                               }
+                       if(count)
+                       {
+                               cout<<" ("<<count<<" targets";
+                               if(ood_count)
+                                       cout<<", "<<ood_count<<" out-of-date";
+                               cout<<')';
+                       }
+                       cout<<'\n';
                }
+       }
+
+       if(analyzer)
+               analyzer->analyze();
+
+       if(!problems.empty())
+       {
+               cerr<<"The following problems were detected:\n";
+               for(ProblemList::iterator i=problems.begin(); i!=problems.end(); ++i)
+                       cerr<<"  "<<i->package<<": "<<i->descr<<'\n';
+               cerr<<"Please fix them and try again.\n";
+               return 1;
+       }
+
+       //if(create_makefile
+
+       if(clean)
+               exit_code=do_clean();
+       else if(build)
+               exit_code=do_build();
+
+       return exit_code;
+}
+
+Package *Builder::get_package(const string &name)
+{
+       PackageMap::iterator i=packages.find(format("%s/%s", name, current_arch->get_name()));
+       if(i==packages.end())
+               i=packages.find(name);
+       if(i!=packages.end())
+               return i->second;
+
+       FS::Path path=get_package_location(name);
+       if(!path.empty() && !load_build_file(path/"Build"))
+       {
+               i=packages.find(name);
+               if(i!=packages.end())
+                       return i->second;
+       }
 
        // Package source not found - create a binary package
-       Package *pkg=BinaryPackage::from_pkgconfig(*this, n);
+       Package *pkg=BinaryPackage::from_pkgconfig(*this, name);
 
-       packages.insert(PackageMap::value_type(n, pkg));
+       packages.insert(PackageMap::value_type(name, pkg));
 
        if(!pkg)
-               problem(n, "not found");
+               problem(name, "not found");
 
        return pkg;
 }
 
-/**
-Returns the target with the given name, or 0 if no such target exists.
-*/
 Target *Builder::get_target(const string &n) const
 {
+       // XXX Used for getting targets by path.  get_target(const FS::Path &)?
        TargetMap::const_iterator i=targets.find(n);
        if(i!=targets.end())
                return i->second;
        return 0;
 }
 
-/**
-Tries to locate a header included from a given location and with a given include
-path.  Considers known targets as well as existing files.  If a matching target
-is not found but a file exists, a new SystemHeader target will be created and
-returned.
-*/
-Target *Builder::get_header(const string &include, const string &arch, const string &from, const list<string> &path)
+Target *Builder::get_header(const string &include, const FS::Path &from, const list<string> &path)
 {
        string hash(8, 0);
-       update_hash(hash, from);
+       if(include[0]=='\"')
+               update_hash(hash, from.str());
        for(list<string>::const_iterator i=path.begin(); i!=path.end(); ++i)
                update_hash(hash, *i);
 
@@ -216,10 +324,10 @@ Target *Builder::get_header(const string &include, const string &arch, const str
        if(cxx_ver.empty())
        {
                StringList argv;
-               argv.push_back(get_architecture(arch).get_tool("CXX"));
+               argv.push_back(current_arch->get_tool("CXX"));
                argv.push_back("--version");
                cxx_ver=Regex("[0-9]\\.[0-9.]+").match(run_command(argv))[0].str;
-               while(!cxx_ver.empty() && !exists(Path("/usr/include/c++")/cxx_ver))
+               while(!cxx_ver.empty() && !FS::is_dir(FS::Path("/usr/include/c++")/cxx_ver))
                {
                        unsigned dot=cxx_ver.rfind('.');
                        if(dot==string::npos)
@@ -235,65 +343,53 @@ Target *Builder::get_header(const string &include, const string &arch, const str
                cout<<"Looking for include "<<fn<<" with path "<<join(path.begin(), path.end())<<'\n';
 
        StringList syspath;
-       if(arch=="native")
+       if(current_arch->is_native())
                syspath.push_back("/usr/include");
        else
-               syspath.push_back("/usr/"+get_architecture(arch).get_prefix()+"/include");
-       syspath.push_back((Path("/usr/include/c++/")/cxx_ver/fn).str());
+               syspath.push_back("/usr/"+current_arch->get_prefix()+"/include");
+       syspath.push_back((FS::Path("/usr/include/c++/")/cxx_ver).str());
 
        Target *tgt=0;
        if(include[0]=='\"')
-               tgt=get_header(Path(from)/fn);
+               tgt=get_header(FS::Path(from)/fn);
        for(list<string>::const_iterator j=path.begin(); (!tgt && j!=path.end()); ++j)
                tgt=get_header(cwd/ *j/fn);
        for(list<string>::const_iterator j=syspath.begin(); (!tgt && j!=syspath.end()); ++j)
-               tgt=get_header(Path(*j)/fn);
+               tgt=get_header(FS::Path(*j)/fn);
 
        includes.insert(TargetMap::value_type(id, tgt));
 
        return tgt;
 }
 
-/**
-Tries to locate a library with the given library path.  Considers known targets
-as well as existing files.  If a matching target is not found but a file exists,
-a new SystemLibrary target will be created and returned.
-
-@param   lib   Name of the library to get (without "lib" prefix or extension)
-@param   path  List of paths to search for the library
-@param   mode  Shared / static mode
-
-@return  Some kind of library target, if a match was found
-*/
-Target *Builder::get_library(const string &lib, const string &arch, const list<string> &path, LibMode mode)
+Target *Builder::get_library(const string &lib, const list<string> &path, LibMode mode)
 {
        string hash(8, 0);
        for(list<string>::const_iterator i=path.begin(); i!=path.end(); ++i)
                update_hash(hash, *i);
 
-       //XXX Incorporate mode into id
-       string id=hash+lib;
+       string id=hash+string(1, mode)+lib;
        TargetMap::iterator i=libraries.find(id);
        if(i!=libraries.end())
                return i->second;
 
        StringList syspath;
-       if(arch=="native")
+       if(current_arch->is_native())
        {
                syspath.push_back("/lib");
                syspath.push_back("/usr/lib");
        }
        else
-               syspath.push_back("/usr/"+get_architecture(arch).get_prefix()+"/lib");
+               syspath.push_back("/usr/"+current_arch->get_prefix()+"/lib");
 
        if(verbose>=5)
                cout<<"Looking for library "<<lib<<" with path "<<join(path.begin(), path.end())<<'\n';
 
        Target *tgt=0;
        for(StringList::const_iterator j=path.begin(); (!tgt && j!=path.end()); ++j)
-               tgt=get_library(lib, arch, cwd/ *j, mode);
+               tgt=get_library(lib, cwd/ *j, mode);
        for(StringList::iterator j=syspath.begin(); (!tgt && j!=syspath.end()); ++j)
-               tgt=get_library(lib, arch, *j, mode);
+               tgt=get_library(lib, *j, mode);
 
        libraries.insert(TargetMap::value_type(id, tgt));
 
@@ -304,7 +400,7 @@ const Architecture &Builder::get_architecture(const string &arch) const
 {
        ArchMap::const_iterator i=archs.find(arch);
        if(i==archs.end())
-               throw InvalidParameterValue("Unknown architecture");
+               throw KeyError("Unknown architecture", arch);
 
        return i->second;
 }
@@ -328,116 +424,19 @@ void Builder::problem(const string &p, const string &d)
        problems.push_back(Problem(p, d));
 }
 
-/**
-Adds a target to both the target map and the new target queue.  Called from
-Target constructor.
-*/
 void Builder::add_target(Target *t)
 {
        targets.insert(TargetMap::value_type(t->get_name(), t));
        new_tgts.push_back(t);
 }
 
-int Builder::main()
-{
-       if(load_build_file(cwd/build_file))
-       {
-               cerr<<"No build info here.\n";
-               return 1;
-       }
-
-       main_pkg->configure(cmdline_options, conf_all?2:1);
-
-       if(help)
-       {
-               usage(0, "builder", false);
-               cout<<'\n';
-               package_help();
-               return 0;
-       }
-
-       if(!conf_only && create_targets())
-               return 1;
-
-       PackageList all_reqs=main_pkg->collect_requires();
-
-       for(PackageList::const_iterator i=all_reqs.begin(); i!=all_reqs.end(); ++i)
-       {
-               SourcePackage *spkg=dynamic_cast<SourcePackage *>(*i);
-               string prob;
-               if(spkg && spkg->get_arch()!=main_pkg->get_arch())
-                       problem(spkg->get_name(), format("wrong architecture (%s)", spkg->get_arch()));
-       }
-
-       if(conf_only)
-               return 0;
-
-       cout<<all_reqs.size()<<" active packages, "<<targets.size()<<" targets\n";
-       if(verbose>=2)
-       {
-               for(PackageList::const_iterator i=all_reqs.begin(); i!=all_reqs.end(); ++i)
-               {
-                       cout<<' '<<(*i)->get_name();
-                       if(dynamic_cast<SourcePackage *>(*i))
-                               cout<<'*';
-                       unsigned count=0;
-                       unsigned ood_count=0;
-                       for(TargetMap::iterator j=targets.begin(); j!=targets.end(); ++j)
-                               if(j->second->get_package()==*i)
-                               {
-                                       ++count;
-                                       if(j->second->get_rebuild())
-                                               ++ood_count;
-                               }
-                       if(count)
-                       {
-                               cout<<" ("<<count<<" targets";
-                               if(ood_count)
-                                       cout<<", "<<ood_count<<" out-of-date";
-                               cout<<')';
-                       }
-                       cout<<'\n';
-               }
-       }
-
-       if(analyzer)
-               analyzer->analyze();
-
-       if(!problems.empty())
-       {
-               cerr<<"The following problems were detected:\n";
-               for(ProblemList::iterator i=problems.begin(); i!=problems.end(); ++i)
-                       cerr<<"  "<<i->package<<": "<<i->descr<<'\n';
-               cerr<<"Please fix them and try again.\n";
-               return 1;
-       }
-
-       //if(create_makefile
-
-       if(clean)
-               exit_code=do_clean();
-       else if(build)
-               exit_code=do_build();
-
-       return exit_code;
-}
-
-Builder::~Builder()
-{
-       for(PackageMap::iterator i=packages.begin(); i!=packages.end(); ++i)
-               delete i->second;
-       for(TargetMap::iterator i=targets.begin(); i!=targets.end(); ++i)
-               delete i->second;
-       delete analyzer;
-}
-
 void Builder::usage(const char *reason, const char *argv0, bool brief)
 {
        if(reason)
                cerr<<reason<<'\n';
 
        if(brief)
-               cerr<<"Usage: "<<argv0<<" [-a|--analyze MODE] [-b|--build] [-c|--clean] [-f|--file FILE] [-h|--help] [-j|--jobs NUM] [-n||--dry-run] [-v|--verbose] [-A|--conf-all] [-B|--build-all] [-C|--chdir DIRECTORY] [-W|--what-if FILE] [--chrome] [--conf-only] [--full-paths] [--max-depth NUM] [<target> ...]";
+               cerr<<"Usage: "<<argv0<<" [-a|--analyze MODE] [-b|--build] [-c|--clean] [-f|--file FILE] [-h|--help] [-j|--jobs NUM] [-n||--dry-run] [-v|--verbose] [-A|--conf-all] [-B|--build-all] [-C|--chdir DIRECTORY] [-W|--what-if FILE] [--chrome] [--conf-only] [--full-paths] [--max-depth NUM] [<target> ...]\n";
        else
        {
                cerr<<
@@ -457,41 +456,84 @@ void Builder::usage(const char *reason, const char *argv0, bool brief)
                        "  -C, --chdir DIR     Change to DIR before doing anything else.\n"
                        "  -P, --progress      Display progress while building.\n"
                        "  -W, --what-if FILE  Pretend that FILE has changed.\n"
+                       "  --arch ARCH         Architecture to build for.\n"
                        "  --conf-only         Stop after configuring packages.\n"
                        "  --full-paths        Output full paths in analysis.\n"
                        //"  --makefile          Create a makefile for this package.\n"
-                       "  --max-depth NUM     Maximum depth to show in analysis.\n";
+                       "  --max-depth NUM     Maximum depth to show in analysis.\n"
+                       "  --prefix DIR        Directory to install things to.\n"
+                       "  --warnings LIST     Compiler warnings to use.\n";
        }
 }
 
-/**
-Loads the given build file.
+FS::Path Builder::get_package_location(const string &name)
+{
+       if(verbose>=3)
+               cout<<"Looking for package "<<name<<'\n';
 
-@param   fn  Path to the file
+       // Try to get source directory with pkgconfig
+       list<string> argv;
+       argv.push_back("pkg-config");
+       argv.push_back("--variable=source");
+       argv.push_back(name);
+       if(verbose>=4)
+               cout<<"Running "<<join(argv.begin(), argv.end())<<'\n';
+       string srcdir=strip(run_command(argv));
+       if(!srcdir.empty())
+               return srcdir;
 
-@return  0 on success, -1 if the file could not be opened
-*/
-int Builder::load_build_file(const Path &fn)
+       if(pkg_dirs.empty())
+       {
+               for(list<FS::Path>::const_iterator i=pkg_path.begin(); i!=pkg_path.end(); ++i)
+               {
+                       list<string> files=list_files(*i);
+                       for(list<string>::const_iterator j=files.begin(); j!=files.end(); ++j)
+                       {
+                               FS::Path full=*i / *j;
+                               if(FS::exists(full/"Build"))
+                                       pkg_dirs.push_back(full);
+                       }
+               }
+               if(verbose>=3)
+                       cout<<pkg_dirs.size()<<" packages found in path\n";
+       }
+
+       bool msp=!name.compare(0, 3, "msp");
+       for(list<FS::Path>::const_iterator i=pkg_dirs.begin(); i!=pkg_dirs.end(); ++i)
+       {
+               string base=basename(*i);
+               unsigned dash=base.rfind('-');
+
+               if(!base.compare(0, dash, name))
+                       return *i;
+               else if(msp && !base.compare(0, dash-3, name, 3, string::npos))
+                       return *i;
+       }
+
+       return FS::Path();
+}
+
+int Builder::load_build_file(const FS::Path &fn)
 {
-       IO::File inf(fn.str());
-       IO::Buffered in(inf);
+       try
+       {
+               IO::BufferedFile in(fn.str());
 
-       if(verbose>=3)
-               cout<<"Reading "<<fn<<'\n';
+               if(verbose>=3)
+                       cout<<"Reading "<<fn<<'\n';
 
-       DataFile::Parser parser(in, fn.str());
-       Loader loader(*this, fn.subpath(0, fn.size()-1));
-       loader.load(parser);
+               DataFile::Parser parser(in, fn.str());
+               Loader loader(*this, fn.subpath(0, fn.size()-1));
+               loader.load(parser);
+       }
+       catch(const IO::FileNotFound &)
+       {
+               return -1;
+       }
 
        return 0;
 }
 
-/**
-Creates targets for all packages and prepares them for building.
-
-@return  0 if everything went ok, -1 if something bad happened and a build
-         shouldn't be attempted
-*/
 int Builder::create_targets()
 {
        Target *world=new VirtualTarget(*this, "world");
@@ -566,8 +608,10 @@ int Builder::create_targets()
        }
 
        /* If world is to be built, prepare cmdline.  If not, add cmdline to world
-          and prepare world.  I don't really like this, but it keeps the graph
-          acyclic. */
+       and prepare world.  I don't really like this, but it keeps the graph
+       acyclic.
+       
+       XXX Could we skip preparing targets we are not interested in? */
        if(build_world)
                cmdline->prepare();
        else
@@ -583,16 +627,12 @@ int Builder::create_targets()
        return 0;
 }
 
-/**
-Check if a header exists, either as a target or a file.  Either an existing
-target or a new SystemHeader target will be returned.
-*/
-Target *Builder::get_header(const Msp::Path &fn)
+Target *Builder::get_header(const Msp::FS::Path &fn)
 {
        Target *tgt=get_target(fn.str());
        if(tgt) return tgt;
 
-       if(exists(fn))
+       if(FS::is_reg(fn))
        {
                tgt=new SystemHeader(*this, fn.str());
                return tgt;
@@ -600,14 +640,14 @@ Target *Builder::get_header(const Msp::Path &fn)
        return 0;
 }
 
-Target *Builder::get_library(const string &lib, const string &arch, const Path &path, LibMode mode)
+Target *Builder::get_library(const string &lib, const FS::Path &path, LibMode mode)
 {
        // Populate a list of candidate filenames
        StringList candidates;
 
        if(mode!=ALL_STATIC)
        {
-               if(arch=="win32")
+               if(current_arch->get_name()=="win32")
                {
                        candidates.push_back("lib"+lib+".dll");
                        candidates.push_back(lib+".dll");
@@ -619,7 +659,7 @@ Target *Builder::get_library(const string &lib, const string &arch, const Path &
        /* Static libraries are always considered, since sometimes shared versions
        may not be available */
        candidates.push_back("lib"+lib+".a");
-       if(arch=="win32")
+       if(current_arch->get_name()=="win32")
                candidates.push_back("lib"+lib+".dll.a");
 
        for(StringList::iterator i=candidates.begin(); i!=candidates.end(); ++i)
@@ -630,8 +670,8 @@ Target *Builder::get_library(const string &lib, const string &arch, const Path &
                if(tgt)
                {
                        Target *real_tgt=tgt;
-                       if(dynamic_cast<Install *>(tgt))
-                               real_tgt=real_tgt->get_depends().front();
+                       if(Install *inst=dynamic_cast<Install *>(tgt))
+                               real_tgt=&inst->get_source();
 
                        /* Ignore dynamic libraries from local packages unless library mode is
                        DYNAMIC */
@@ -640,7 +680,7 @@ Target *Builder::get_library(const string &lib, const string &arch, const Path &
                        else if(tgt)
                                return tgt;
                }
-               else if(exists(full))
+               else if(FS::is_reg(full))
                {
                        tgt=new SystemLibrary(*this, full);
                        return tgt;
@@ -650,19 +690,6 @@ Target *Builder::get_library(const string &lib, const string &arch, const Path &
        return 0;
 }
 
-/**
-Updates a hash with a string.  This is used from get_header and get_library.
-*/
-void Builder::update_hash(string &hash, const string &value)
-{
-       for(unsigned i=0; i<value.size(); ++i)
-               hash[i%hash.size()]^=value[i];
-}
-
-/**
-This function supervises the build process, starting new actions when slots
-become available.
-*/
 int Builder::do_build()
 {
        Target *cmdline=get_target("cmdline");
@@ -673,7 +700,8 @@ int Builder::do_build()
                cout<<"Already up to date\n";
                return 0;
        }
-       cout<<"Will build "<<total<<" target(s)\n";
+       if(verbose>=1)
+               cout<<"Will build "<<total<<" target(s)\n";
 
        vector<Action *> actions;
 
@@ -734,10 +762,6 @@ int Builder::do_build()
        return fail?1:0;
 }
 
-/**
-Cleans buildable targets.  If clean is 1, cleans only this package.  If
-clean is 2 or greater, cleans all buildable packages.
-*/
 int Builder::do_clean()
 {
        // Cleaning doesn't care about ordering, so a simpler method can be used
@@ -761,18 +785,16 @@ int Builder::do_clean()
        }
 
        for(set<Target *>::iterator i=clean_tgts.begin(); i!=clean_tgts.end(); ++i)
-       {
-               Action *action=new Unlink(*this, **i);
-               while(action->check()<0);
-               delete action;
-       }
+               if(FileTarget *ft=dynamic_cast<FileTarget *>(*i))
+               {
+                       Action *action=new Unlink(*this, *ft);
+                       while(action->check()<0) ;
+                       delete action;
+               }
 
        return 0;
 }
 
-/**
-Prints out information about the default package.
-*/
 void Builder::package_help()
 {
        const Config &config=main_pkg->get_config();
@@ -798,7 +820,7 @@ void Builder::package_help()
 Application::RegApp<Builder> Builder::reg;
 
 
-Builder::Loader::Loader(Builder &b, const Path &s):
+Builder::Loader::Loader(Builder &b, const FS::Path &s):
        bld(b),
        src(s)
 {
@@ -825,7 +847,8 @@ void Builder::Loader::binpkg(const string &n)
 void Builder::Loader::profile(const string &n)
 {
        StringMap prf;
-       load_sub<ProfileLoader>(prf);
+       ProfileLoader ldr(prf);
+       load_sub_with(ldr);
        bld.profile_tmpl.insert(ProfileTemplateMap::value_type(n, prf));
 }