2 #include <msp/core/algorithm.h>
3 #include <msp/core/raii.h>
4 #include <msp/strings/format.h>
5 #include <msp/strings/utils.h>
15 void Validator::diagnose(Node &node, Node &provoking_node, Diagnostic::Severity severity, const string &message)
18 diag.severity = severity;
19 diag.source = node.source;
20 diag.line = node.line;
21 diag.provoking_source = provoking_node.source;
22 diag.provoking_line = provoking_node.line;
23 diag.message = message;
24 stage->diagnostics.push_back(diag);
26 last_provoker = &provoking_node;
29 void Validator::add_info(Node &node, const string &message)
32 throw logic_error("Tried to add info without a previous provoker");
33 diagnose(node, *last_provoker, Diagnostic::INFO, message);
37 void DeclarationValidator::apply(Stage &s, const Features &f)
41 s.content.visit(*this);
44 const char *DeclarationValidator::describe_variable(ScopeType scope)
48 case GLOBAL: return "global variable";
49 case STRUCT: return "struct member";
50 case INTERFACE_BLOCK: return "interface block member";
51 case FUNCTION_PARAM: return "function parameter";
52 case FUNCTION: return "local variable";
53 default: return "variable";
57 void DeclarationValidator::visit(Layout &layout)
59 bool push_constant = false;
61 for(const Layout::Qualifier &q: layout.qualifiers)
66 if(q.name=="location")
67 allowed = (variable && scope==GLOBAL);
68 else if(q.name=="binding" || q.name=="set")
72 if(q.name=="set" && features.target_api!=VULKAN)
74 error(layout, "Layout qualifier 'set' not allowed when targeting OpenGL");
80 const TypeDeclaration *base_type = get_ultimate_base_type(variable->type_declaration);
81 bool uniform = (variable->interface=="uniform");
82 allowed = (scope==GLOBAL && uniform && dynamic_cast<const ImageTypeDeclaration *>(base_type));
83 err_descr = (uniform ? "variable of non-opaque type" : "non-uniform variable");
87 allowed = (iface_block->interface=="uniform");
88 err_descr = "non-uniform interface block";
91 else if(q.name=="constant_id")
93 allowed = (variable && scope==GLOBAL);
96 if(!variable->constant)
99 err_descr = "non-constant variable";
103 BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(variable->type_declaration);
104 if(!basic || basic->kind<BasicTypeDeclaration::BOOL || basic->kind>BasicTypeDeclaration::INT)
107 err_descr = format("variable of type '%s'",
108 (variable->type_declaration ? variable->type_declaration->name : variable->type));
113 else if(q.name=="offset")
114 allowed = (variable && scope==INTERFACE_BLOCK && iface_block->interface=="uniform");
115 else if(q.name=="align")
116 allowed = (scope==INTERFACE_BLOCK && iface_block->interface=="uniform");
117 else if(q.name=="points")
119 allowed = (stage->type==Stage::GEOMETRY && iface_layout && (iface_layout->interface=="in" || iface_layout->interface=="out"));
122 else if(q.name=="lines" || q.name=="lines_adjacency" || q.name=="triangles" || q.name=="triangles_adjacency")
124 allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="in");
127 else if(q.name=="line_strip" || q.name=="triangle_strip")
129 allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="out");
132 else if(q.name=="invocations")
133 allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="in");
134 else if(q.name=="max_vertices")
135 allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="out");
136 else if(q.name=="std140" || q.name=="std430")
138 allowed = (iface_block && !variable && iface_block->interface=="uniform");
141 else if(q.name=="column_major" || q.name=="row_major")
143 allowed = (variable && scope==INTERFACE_BLOCK);
146 BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(variable->type_declaration);
147 while(basic && basic->kind==BasicTypeDeclaration::ARRAY)
148 basic = dynamic_cast<BasicTypeDeclaration *>(basic->base_type);
149 allowed = (basic && basic->kind==BasicTypeDeclaration::MATRIX);
150 err_descr = "non-matrix variable";
153 else if(q.name=="push_constant")
155 push_constant = true;
156 allowed = (iface_block && !variable && iface_block->interface=="uniform");
159 else if(q.name=="local_size_x" || q.name=="local_size_y" || q.name=="local_size_z")
160 allowed = (stage->type==Stage::COMPUTE && iface_layout && iface_layout->interface=="in");
161 else if(q.name=="rgba32f" || q.name=="rgba16f" || q.name=="rg32f" || q.name=="rg16f" || q.name=="r32f" || q.name=="r16f" ||
162 q.name=="rgba16" || q.name=="rgba8" || q.name=="rg16" || q.name=="rg8" || q.name=="r16" || q.name=="r8" ||
163 q.name=="rgba16_snorm" || q.name=="rgba8_snorm" || q.name=="rg16_snorm" || q.name=="rg8_snorm" || q.name=="r16_snorm" || q.name=="r8_snorm")
169 const TypeDeclaration *base_type = get_ultimate_base_type(variable->type_declaration);
170 const ImageTypeDeclaration *image = dynamic_cast<const ImageTypeDeclaration *>(base_type);
171 allowed = (image && !image->sampled);
172 err_descr = (image ? "sampled image" : "non-image variable");
178 if(err_descr.empty())
181 err_descr = describe_variable(scope);
183 err_descr = "interface block";
184 else if(iface_layout)
185 err_descr = format("interface '%s'", iface_layout->interface);
187 err_descr = "unknown declaration";
189 error(layout, format("Layout qualifier '%s' not allowed on %s", q.name, err_descr));
191 else if(value && !q.has_value)
192 error(layout, format("Layout qualifier '%s' requires a value", q.name));
193 else if(!value && q.has_value)
194 error(layout, format("Layout qualifier '%s' does not allow a value", q.name));
197 if(push_constant && binding)
198 error(layout, "Layout qualifier 'push_constant' not allowed together with 'binding' or 'set'");
201 void DeclarationValidator::visit(InterfaceLayout &layout)
203 SetForScope<InterfaceLayout *> set_layout(iface_layout, &layout);
204 TraversingVisitor::visit(layout);
207 void DeclarationValidator::visit(BasicTypeDeclaration &type)
209 BasicTypeDeclaration *basic_base = dynamic_cast<BasicTypeDeclaration *>(type.base_type);
210 BasicTypeDeclaration::Kind base_kind = (basic_base ? basic_base->kind : BasicTypeDeclaration::VOID);
212 if(type.kind==BasicTypeDeclaration::VECTOR && (base_kind<BasicTypeDeclaration::BOOL || base_kind>BasicTypeDeclaration::FLOAT))
213 error(type, format("Invalid base type '%s' for vector type '%s'", type.base, type.name));
214 else if(type.kind==BasicTypeDeclaration::MATRIX && base_kind!=BasicTypeDeclaration::VECTOR)
215 error(type, format("Invalid base type '%s' for matrix type '%s'", type.base, type.name));
216 else if(type.kind==BasicTypeDeclaration::ARRAY && basic_base && base_kind==BasicTypeDeclaration::VOID)
217 error(type, format("Invalid base type '%s' for array type '%s'", type.base, type.name));
220 void DeclarationValidator::visit(ImageTypeDeclaration &type)
222 BasicTypeDeclaration::Kind base_kind = BasicTypeDeclaration::VOID;
223 if(BasicTypeDeclaration *basic_base = dynamic_cast<BasicTypeDeclaration *>(type.base_type))
224 base_kind = basic_base->kind;
225 if(base_kind!=BasicTypeDeclaration::INT && base_kind!=BasicTypeDeclaration::FLOAT)
226 error(type, format("Invalid base type '%s' for image type '%s'", type.base, type.name));
229 void DeclarationValidator::visit(StructDeclaration &strct)
231 SetForScope<ScopeType> set_scope(scope, (strct.block_name.empty() ? STRUCT : INTERFACE_BLOCK));
232 SetForScope<VariableDeclaration *> set_iface(iface_block, strct.block_declaration);
233 TraversingVisitor::visit(strct);
236 void DeclarationValidator::visit(VariableDeclaration &var)
238 SetForScope<VariableDeclaration *> set_var((var.block_declaration ? iface_block : variable), &var);
240 const char *descr = describe_variable(scope);
244 if(scope!=GLOBAL && scope!=INTERFACE_BLOCK)
245 error(var, format("Layout qualifier not allowed on %s", descr));
247 var.layout->visit(*this);
252 if(scope==STRUCT || scope==INTERFACE_BLOCK)
253 error(var, format("Constant qualifier not allowed on %s", descr));
254 if(!var.init_expression)
255 error(var, "Constant variable must have an initializer");
258 if(!var.interpolation.empty() || !var.sampling.empty())
260 if(var.interface!="in" && stage->type==Stage::VERTEX)
261 error(var, "Interpolation qualifier not allowed on vertex input");
262 else if(var.interface!="out" && stage->type==Stage::FRAGMENT)
263 error(var, "Interpolation qualifier not allowed on fragment output");
264 else if((var.interface!="in" && var.interface!="out") || (scope==FUNCTION_PARAM || scope==FUNCTION))
265 error(var, "Interpolation qualifier not allowed on non-interpolated variable");
268 if(!var.interface.empty())
270 if(iface_block && var.interface!=iface_block->interface)
271 error(var, format("Mismatched interface qualifier '%s' inside '%s' block", var.interface, iface_block->interface));
272 else if(scope==STRUCT || scope==FUNCTION)
273 error(var, format("Interface qualifier not allowed on %s", descr));
274 else if(scope==GLOBAL && var.interface=="uniform" && !var.block_declaration && features.target_api==VULKAN)
276 if(!dynamic_cast<const ImageTypeDeclaration *>(get_ultimate_base_type(var.type_declaration)))
277 error(var, "Interface qualifier 'uniform' not allowed on non-opaque variable in global scope");
281 TypeDeclaration *type = var.type_declaration;
282 BasicTypeDeclaration::Kind kind = BasicTypeDeclaration::ALIAS;
283 while(BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(type))
286 type = basic->base_type;
288 if(dynamic_cast<ImageTypeDeclaration *>(type))
290 if(scope!=GLOBAL && scope!=FUNCTION_PARAM)
291 error(var, format("Type '%s' not allowed on %s", type->name, descr));
292 else if(scope==GLOBAL && var.interface!="uniform")
293 error(var, format("Type '%s' only allowed with uniform interface", type->name));
295 else if(var.block_declaration)
297 if(stage->type==Stage::VERTEX && var.interface=="in")
298 error(var, "Interface block not allowed on vertex shader input");
299 else if(stage->type==Stage::FRAGMENT && var.interface=="out")
300 error(var, "Interface block not allowed on fragment shader output");
302 else if(kind==BasicTypeDeclaration::VOID)
303 error(var, "Type 'void' not allowed on variable");
304 else if(kind==BasicTypeDeclaration::BOOL && var.source!=BUILTIN_SOURCE)
306 if(scope==INTERFACE_BLOCK)
307 error(var, "Type 'bool' not allowed in an interface block");
308 else if(!var.interface.empty())
309 error(var, "Type 'bool' not allowed on interface variable");
312 if(var.array && !var.array_size)
313 error(var, "Array must have a size");
315 if(var.init_expression)
317 if(scope==GLOBAL && !var.constant)
318 error(var, format("Initializer not allowed on non-constant %s", descr));
319 else if(scope!=GLOBAL && scope!=FUNCTION)
320 error(var, format("Initializer not allowed on %s", descr));
322 var.init_expression->visit(*this);
326 void DeclarationValidator::visit(FunctionDeclaration &func)
328 SetForScope<ScopeType> set_scope(scope, FUNCTION_PARAM);
329 for(const RefPtr<VariableDeclaration> &p: func.parameters)
332 func.body.visit(*this);
336 void IdentifierValidator::multiple_definition(const string &name, Statement &statement, Statement &previous)
338 error(statement, format("Multiple definition of %s", name));
339 add_info(previous, "Previous definition is here");
342 Statement *IdentifierValidator::find_definition(const string &name)
344 BlockDeclarationMap *decls = &declarations[current_block];
345 auto i = decls->find(name);
346 if(i==decls->end() && anonymous_block)
348 decls = &declarations[current_block->parent];
349 i = decls->find(name);
351 return (i!=decls->end() ? i->second : 0);
354 void IdentifierValidator::check_definition(const string &name, Statement &statement)
356 if(Statement *previous = find_definition(name))
357 multiple_definition(format("'%s'", name), statement, *previous);
359 record_definition(name, statement);
362 void IdentifierValidator::record_definition(const string &name, Statement &statement)
364 declarations[current_block].insert(make_pair(name, &statement));
366 declarations[current_block->parent].insert(make_pair(name, &statement));
369 void IdentifierValidator::visit(TypeDeclaration &type)
371 if(type.source!=INTERNAL_SOURCE)
372 check_definition(type.name, type);
375 void IdentifierValidator::visit(StructDeclaration &strct)
377 if(strct.block_name.empty())
378 check_definition(strct.name, strct);
379 TraversingVisitor::visit(strct);
382 void IdentifierValidator::visit(VariableDeclaration &var)
384 if(var.block_declaration)
386 string key = format("%s %s", var.interface, var.block_declaration->block_name);
387 auto i = interface_blocks.find(key);
388 if(i!=interface_blocks.end())
389 multiple_definition(format("interface block '%s %s'", var.interface, var.block_declaration->block_name), var, *i->second);
391 interface_blocks.insert(make_pair(key, &var));
393 if(Statement *previous = find_definition(var.block_declaration->block_name))
395 const VariableDeclaration *prev_var = dynamic_cast<const VariableDeclaration *>(previous);
396 if(!prev_var || !prev_var->block_declaration)
397 multiple_definition(format("'%s'", var.block_declaration->block_name), var, *previous);
400 record_definition(var.block_declaration->block_name, var);
402 if(var.name.find(' ')!=string::npos)
404 // Inject anonymous interface block members into the global scope
405 for(const auto &kvp: var.block_declaration->members.variables)
406 check_definition(kvp.first, *kvp.second);
410 if(var.name.find(' ')==string::npos)
411 check_definition(var.name, var);
413 TraversingVisitor::visit(var);
416 void IdentifierValidator::visit(FunctionDeclaration &func)
418 string key = func.name+func.signature;
419 auto i = overloaded_functions.find(key);
420 if(i==overloaded_functions.end())
421 overloaded_functions.insert(make_pair(key, &func));
422 else if(func.return_type_declaration && i->second->return_type_declaration!=func.return_type_declaration)
424 error(func, format("Conflicting return type '%s' for function '%s'", func.return_type_declaration->name, func.name));
425 if(i->second->return_type_declaration)
426 add_info(*i->second, format("Previously declared as returning '%s'", i->second->return_type_declaration->name));
429 if(Statement *previous = find_definition(func.name))
431 if(!dynamic_cast<FunctionDeclaration *>(previous))
432 multiple_definition(format("'%s'", func.name), func, *previous);
435 record_definition(func.name, func);
437 if(func.definition==&func)
438 check_definition(func.name+func.signature, func);
440 TraversingVisitor::visit(func);
444 void ReferenceValidator::visit(BasicTypeDeclaration &type)
446 if(!type.base.empty() && !type.base_type)
447 error(type, format("Use of undeclared type '%s'", type.base));
450 void ReferenceValidator::visit(ImageTypeDeclaration &type)
452 if(!type.base.empty() && !type.base_type)
453 error(type, format("Use of undeclared type '%s'", type.base));
456 void ReferenceValidator::visit(VariableReference &var)
459 error(var, format("Use of undeclared variable '%s'", var.name));
460 else if(stage->type!=Stage::VERTEX && var.declaration->interface=="in" && var.name.compare(0, 3, "gl_") && !var.declaration->linked_declaration)
461 error(var, format("Use of unlinked input %s '%s'", (var.declaration->block_declaration ? "block" : "variable"), var.name));
464 void ReferenceValidator::visit(MemberAccess &memacc)
466 if(memacc.left->type && !memacc.declaration)
467 error(memacc, format("Use of undeclared member '%s'", memacc.member));
468 TraversingVisitor::visit(memacc);
471 void ReferenceValidator::visit(FunctionCall &call)
473 if((!call.constructor && !call.declaration) || (call.constructor && !call.type))
475 bool have_declaration = call.constructor;
476 if(!call.constructor)
478 auto i = stage->functions.lower_bound(call.name);
479 have_declaration = (i!=stage->functions.end() && i->second->name==call.name);
484 bool valid_types = true;
486 for(auto j=call.arguments.begin(); (valid_types && j!=call.arguments.end()); ++j)
489 append(signature, ", ", (*j)->type->name);
495 error(call, format("No matching %s found for '%s(%s)'", (call.constructor ? "constructor" : "overload"), call.name, signature));
498 error(call, format("Call to undeclared function '%s'", call.name));
500 TraversingVisitor::visit(call);
503 void ReferenceValidator::visit(VariableDeclaration &var)
505 if(!var.type_declaration)
506 error(var, format("Use of undeclared type '%s'", var.type));
507 TraversingVisitor::visit(var);
510 void ReferenceValidator::visit(FunctionDeclaration &func)
512 if(!func.return_type_declaration)
513 error(func, format("Use of undeclared type '%s'", func.return_type));
514 TraversingVisitor::visit(func);
518 void ExpressionValidator::visit(VariableReference &var)
520 if(var.declaration && constant_expression)
522 if(!var.declaration->constant)
524 const char *kind = (var.declaration->block_declaration ? "interface block" : "non-constant variable");
525 error(var, format("Reference to %s '%s' in a constant expression", kind, var.name));
527 else if(var.declaration->layout && constant_expression==FIXED_CONSTANT)
529 if(has_layout_qualifier(var.declaration->layout.get(), "constant_id"))
530 error(var, format("Reference to specialization constant '%s' in a fixed constant expression", var.name));
535 void ExpressionValidator::visit(Swizzle &swizzle)
538 if(BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(swizzle.left->type))
540 if(basic->kind==BasicTypeDeclaration::INT || basic->kind==BasicTypeDeclaration::FLOAT)
542 else if(basic->kind==BasicTypeDeclaration::VECTOR)
548 static const char component_names[] = { 'x', 'y', 'z', 'w', 'r', 'g', 'b', 'a', 's', 't', 'p', 'q' };
550 for(unsigned i=0; i<swizzle.count; ++i)
552 unsigned component_flavour = (std::find(component_names, component_names+12, swizzle.component_group[i])-component_names)/4;
554 flavour = component_flavour;
555 else if(flavour>=0 && component_flavour!=static_cast<unsigned>(flavour))
557 error(swizzle, format("Flavour of swizzle component '%c' is inconsistent with '%c'",
558 swizzle.component_group[i], swizzle.component_group[0]));
562 if(swizzle.components[i]>=size)
563 error(swizzle, format("Access to component '%c' which is not present in '%s'",
564 swizzle.component_group[i], swizzle.left->type->name));
567 else if(swizzle.left->type)
568 error(swizzle, format("Swizzle applied to '%s' which is neither a scalar nor a vector", swizzle.left->type->name));
570 TraversingVisitor::visit(swizzle);
573 void ExpressionValidator::visit(UnaryExpression &unary)
575 if(unary.expression->type)
578 error(unary, format("No matching operator '%s' found for '%s'", unary.oper->token, unary.expression->type->name));
579 else if(unary.oper->token[1]=='+' || unary.oper->token[1]=='-')
581 if(constant_expression)
582 error(unary, format("Use of '%s' in a constant expression", unary.oper->token));
583 else if(!unary.expression->lvalue)
584 error(unary, format("Operand of '%s' is not an lvalue", unary.oper->token));
587 TraversingVisitor::visit(unary);
590 void ExpressionValidator::visit(BinaryExpression &binary)
592 if(!binary.type && binary.left->type && binary.right->type)
594 if(binary.oper->token[0]=='[')
595 error(binary, format("Can't index element of '%s' with '%s'",
596 binary.left->type->name, binary.right->type->name));
598 error(binary, format("No matching operator '%s' found for '%s' and '%s'",
599 binary.oper->token, binary.left->type->name, binary.right->type->name));
601 TraversingVisitor::visit(binary);
604 void ExpressionValidator::visit(Assignment &assign)
606 if(assign.left->type)
608 if(constant_expression)
609 error(assign, "Assignment in constant expression");
610 else if(!assign.left->lvalue)
611 error(assign, "Target of assignment is not an lvalue");
612 if(assign.right->type)
614 if(assign.oper->token[0]!='=')
617 error(assign, format("No matching operator '%s' found for '%s' and '%s'",
618 string(assign.oper->token, strlen(assign.oper->token)-1), assign.left->type->name, assign.right->type->name));
620 else if(assign.left->type!=assign.right->type)
621 error(assign, format("Assignment to variable of type '%s' from expression of incompatible type '%s'",
622 assign.left->type->name, assign.right->type->name));
625 TraversingVisitor::visit(assign);
628 void ExpressionValidator::visit(TernaryExpression &ternary)
630 if(ternary.condition->type)
632 BasicTypeDeclaration *basic_cond = dynamic_cast<BasicTypeDeclaration *>(ternary.condition->type);
633 if(!basic_cond || basic_cond->kind!=BasicTypeDeclaration::BOOL)
634 error(ternary, "Ternary operator condition is not a boolean");
635 else if(!ternary.type && ternary.true_expr->type && ternary.false_expr->type)
636 error(ternary, format("Ternary operator has incompatible types '%s' and '%s'",
637 ternary.true_expr->type->name, ternary.false_expr->type->name));
639 TraversingVisitor::visit(ternary);
642 void ExpressionValidator::visit(StructDeclaration &strct)
644 SetFlag set_struct(in_struct);
645 TraversingVisitor::visit(strct);
648 void ExpressionValidator::visit(VariableDeclaration &var)
650 if(var.init_expression && var.init_expression->type && var.type_declaration && var.init_expression->type!=var.type_declaration)
651 error(var, format("Initializing a variable of type '%s' with an expression of incompatible type '%s'",
652 var.type_declaration->name, var.init_expression->type->name));
655 var.layout->visit(*this);
656 if(var.init_expression)
658 ConstantKind const_kind = (!var.constant ? NOT_CONSTANT :
659 has_layout_qualifier(var.layout.get(), "constant_id") ? FIXED_CONSTANT : SPEC_CONSTANT);
661 SetForScope<ConstantKind> set_const(constant_expression, const_kind);
662 TraversingVisitor::visit(var.init_expression);
666 SetForScope<ConstantKind> set_const(constant_expression, (in_struct || !var.interface.empty() ? FIXED_CONSTANT : SPEC_CONSTANT));
667 TraversingVisitor::visit(var.array_size);
671 void ExpressionValidator::visit(FunctionDeclaration &func)
673 SetForScope<FunctionDeclaration *> set_func(current_function, &func);
674 TraversingVisitor::visit(func);
677 void ExpressionValidator::visit(Conditional &cond)
679 if(cond.condition->type)
681 BasicTypeDeclaration *basic_cond = dynamic_cast<BasicTypeDeclaration *>(cond.condition->type);
682 if(!basic_cond || basic_cond->kind!=BasicTypeDeclaration::BOOL)
683 error(cond, "Condition is not a boolean");
685 TraversingVisitor::visit(cond);
688 void ExpressionValidator::visit(Iteration &iter)
690 if(iter.condition->type)
692 BasicTypeDeclaration *basic_cond = dynamic_cast<BasicTypeDeclaration *>(iter.condition->type);
693 if(!basic_cond || basic_cond->kind!=BasicTypeDeclaration::BOOL)
694 error(iter, "Loop condition is not a boolean");
696 TraversingVisitor::visit(iter);
699 void ExpressionValidator::visit(Return &ret)
701 if(current_function && current_function->return_type_declaration)
703 TypeDeclaration *return_type = current_function->return_type_declaration;
704 BasicTypeDeclaration *basic_return = dynamic_cast<BasicTypeDeclaration *>(return_type);
707 if(ret.expression->type && ret.expression->type!=return_type)
708 error(ret, format("Return expression type '%s' is incompatible with declared return type '%s'",
709 ret.expression->type->name, return_type->name));
711 else if(!basic_return || basic_return->kind!=BasicTypeDeclaration::VOID)
712 error(ret, "Return statement without an expression in a function not returning 'void'");
715 TraversingVisitor::visit(ret);
719 void FlowControlValidator::visit(Block &block)
721 for(const RefPtr<Statement> &s: block.body)
725 diagnose(*s, Diagnostic::WARN, "Unreachable code detected");
732 void FlowControlValidator::visit(FunctionDeclaration &func)
734 func.body.visit(*this);
736 if(func.definition==&func && func.return_type_declaration)
738 const BasicTypeDeclaration *basic_ret = dynamic_cast<const BasicTypeDeclaration *>(func.return_type_declaration);
739 if(reachable && (!basic_ret || basic_ret->kind!=BasicTypeDeclaration::VOID))
740 error(func, "Missing return statement at the end of a function not returning 'void'");
745 void FlowControlValidator::visit(Conditional &cond)
747 cond.body.visit(*this);
748 bool reachable_if_true = reachable;
750 cond.else_body.visit(*this);
751 reachable |= reachable_if_true;
754 void FlowControlValidator::visit(Iteration &iter)
756 iter.body.visit(*this);
761 void StageInterfaceValidator::visit(VariableDeclaration &var)
763 int location = get_layout_value(var.layout.get(), "location");
764 if(var.interface=="in" && var.linked_declaration)
766 const Layout *linked_layout = var.linked_declaration->layout.get();
767 int linked_location = get_layout_value(linked_layout, "location");
768 if(linked_location!=location)
770 error(var, format("Mismatched location %d for 'in %s'", location, var.name));
771 add_info(*var.linked_declaration, format("Linked to 'out %s' with location %d",
772 var.linked_declaration->name, linked_location));
774 if(var.type_declaration && var.linked_declaration->type_declaration)
776 TypeDeclaration *type = var.type_declaration;
777 if(stage->type==Stage::GEOMETRY)
779 if(const BasicTypeDeclaration *basic = dynamic_cast<const BasicTypeDeclaration *>(type))
780 if(basic->kind==BasicTypeDeclaration::ARRAY && basic->base_type)
781 type = basic->base_type;
783 if(!TypeComparer().apply(*type, *var.linked_declaration->type_declaration))
785 error(var, format("Mismatched type '%s' for 'in %s'", type->name, var.name));
786 add_info(*var.linked_declaration, format("Linked to 'out %s' with type '%s'",
787 var.linked_declaration->name, var.linked_declaration->type_declaration->name));
792 if(location>=0 && !var.interface.empty())
794 map<unsigned, VariableDeclaration *> &used = used_locations[var.interface];
796 unsigned loc_count = LocationCounter().apply(var);
797 for(unsigned i=0; i<loc_count; ++i)
799 auto j = used.find(location+i);
802 error(var, format("Overlapping location %d for '%s %s'", location+i, var.interface, var.name));
803 add_info(*j->second, format("Previously used here for '%s %s'", j->second->interface, j->second->name));
806 used[location+i] = &var;
812 void GlobalInterfaceValidator::apply(Module &module)
814 for(Stage &s: module.stages)
817 s.content.visit(*this);
821 void GlobalInterfaceValidator::check_uniform(const Uniform &uni)
823 auto i = used_names.find(uni.name);
824 if(i!=used_names.end())
826 if(uni.location>=0 && i->second->location>=0 && i->second->location!=uni.location)
828 error(*uni.node, format("Mismatched location %d for uniform '%s'", uni.location, uni.name));
829 add_info(*i->second->node, format("Previously declared here with location %d", i->second->location));
831 if(i->second->desc_set!=uni.desc_set)
833 error(*uni.node, format("Mismatched descriptor set %d for uniform '%s'", uni.desc_set, uni.name));
834 add_info(*i->second->node, format("Previously declared here with descriptor set %d", i->second->desc_set));
836 if(uni.bind_point>=0 && i->second->bind_point>=0 && i->second->bind_point!=uni.bind_point)
838 error(*uni.node, format("Mismatched binding %d for uniform '%s'", uni.bind_point, uni.name));
839 add_info(*i->second->node, format("Previously declared here with binding %d", i->second->bind_point));
841 if(uni.type && i->second->type && !TypeComparer().apply(*uni.type, *i->second->type))
843 string type_name = (dynamic_cast<const StructDeclaration *>(uni.type) ?
844 "structure" : format("type '%s'", uni.type->name));
845 error(*uni.node, format("Mismatched %s for uniform '%s'", type_name, uni.name));
847 string message = "Previously declared here";
848 if(!dynamic_cast<const StructDeclaration *>(i->second->type))
849 message += format(" with type '%s'", i->second->type->name);
850 add_info(*i->second->node, message);
854 used_names.insert(make_pair(uni.name, &uni));
858 auto j = used_locations.find(uni.location);
859 if(j!=used_locations.end())
861 if(j->second->name!=uni.name)
863 error(*uni.node, format("Overlapping location %d for '%s'", uni.location, uni.name));
864 add_info(*j->second->node, format("Previously used here for '%s'", j->second->name));
869 for(unsigned k=0; k<uni.loc_count; ++k)
870 used_locations.insert(make_pair(uni.location+k, &uni));
874 if(uni.bind_point>=0)
876 map<unsigned, const Uniform *> &used = used_bindings[uni.desc_set];
877 auto j = used.find(uni.bind_point);
880 if(j->second->name!=uni.name)
882 error(*uni.node, format("Overlapping binding %d for '%s'", uni.bind_point, uni.name));
883 add_info(*j->second->node, format("Previously used here for '%s'", j->second->name));
887 used.insert(make_pair(uni.bind_point, &uni));
891 void GlobalInterfaceValidator::visit(VariableDeclaration &var)
893 if(var.interface=="uniform")
897 uni.type = var.type_declaration;
898 uni.name = (var.block_declaration ? var.block_declaration->block_name : var.name);
901 if(!var.block_declaration)
903 uni.location = get_layout_value(var.layout.get(), "location");
904 uni.loc_count = LocationCounter().apply(var);
906 uni.desc_set = get_layout_value(var.layout.get(), "set", 0);
907 uni.bind_point = get_layout_value(var.layout.get(), "binding");
910 uniforms.push_back(uni);
911 check_uniform(uniforms.back());